[go: up one dir, main page]

Store: read uint32 while checking snapshot import consistency

This is a followup MR of !12262 (merged).

The offsets of the cemented files are encoded as signed int32 but were decoded as signed int31 while checking the consistency of the cemented stores while importing a snapshot. This was issue when checking cycles containing many big blocks (> ~1Gb cycles).

We now switch to uint32.

Closes: #7144 (closed)

Manually testing the MR

Import a recent ghostnet full snapshot (containing cycle 960, i.e after 15 March 2024) and encounter the error describe in #7144 (closed).

Check that it works with the fix.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Victor Allombert

Merge request reports

Loading