[go: up one dir, main page]

CIAO: before_merging/scheduled, pt 11: concluding clean up

Stack

What

Final MR on the CIAO translation. This ties up some loose ends: removes all external files and the functions for making such files. I also re-organize the definition of the tezt test jobs a little bit.

Why

With the full configuration translated to CIAO, there is no need to write jobs to separate files. Instead, we write one file per pipeline, which contains the full definition of each job that the pipeline uses (no more includes).

How

Manually testing the MR

This MR is best reviewed commit-per-commit for the OCaml part. Commits should have a message explaining any non-obvious changes.

For the generated YML, do review the result of this commands (see previous MRs like !11501 (merged) for setup instructions for gci-tezos):

$ gci-tezos diff-full-config master . all-envs

Note, depending on the state on local checkout, you might get results of the above commands by replacing master with git merge-base origin/master HEAD, where origin might change depending on the name of your tezos git remote. this also requires that you've run a fetch on origin such that it does not lag behind the branch in this MR.

The result of this command should only show a diff in the ordering of tezt dependencies due to the above mentioned tezt refactoring. This diff has no semantic significance.

Checklist

  • Document the interface of any function added or modified (see the coding guidelines)
  • Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Arvid Jakobsson

Merge request reports

Loading