Explode preserved cycles
Context
based on !11300 (merged)
This MR divide finish the division of preserved_cycles constant in several constants with different purpose.
The idea is that preserved cycle is used for different purposes sometimes with narrow link between all its usages.
We retained 3 different usage :
- consensus_rights_delay
- delegate_parameters_activation_delay
-
block_conservation_cyclesblocks_preservation_cycles (for the shell)
As you can see in constants_storage diff, we added other constants as pseudo-paramaters :
- issuance_modification_delay
- adaptive_issuance_activation_delay
- slashable_deposits_period
- tolerated_inactivity_period
- consensus_key_activation_delay
The MR is currently being split into smaller parts to make it more readable: see
-
!11558 (merged) preliminary cleanup -
!11562 (merged) for everything related to delegate_parameters_activation_delay (with extra tests)
and more to come ...
-
pseudo constants !11627 (merged) -
consensus_right_delays everywhere else and remove preserved_cycle + update doc !11629 (merged)
Manually testing the MR
Checklist
-
Document the interface of any function added or modified (see the coding guidelines) -
Document any change to the user interface, including configuration parameters (see node configuration) -
Provide automatic testing (see the testing guide). -
For new features and bug fixes, add an item in the appropriate changelog ( docs/protocols/alpha.rstfor the protocol and the environment,CHANGES.rstat the root of the repository for everything else). -
Select suitable reviewers using the Reviewersfield below. -
Select as Assigneethe next person who should take action on that MR
Edited by Julien