[Feature] Support bounding volume sphere
What does this MR do and why?
This MR adds the support of bounding volume sphere (with the capacity of mixing bounding volume boxes and spheres).
Before these modifications, this MR fixes and improves the transform
method of BoundingVolumeBox
.
How to set up and validate locally
I add the test file test_bounding_volume_sphere.py
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have read the CONTRIBUTING.md guide. -
The changes are correctly documented - No, that's what remains to be done, since
add
methods aren't trivial, I'll take time for that but later.
- No, that's what remains to be done, since
-
the CI is passing -
SonarCloud has validated the changes
Notes
I had to use other_box: BoundingVolumeBox = other # type: ignore[assignment]
to avoid circular import. If you have a better solution, I will take it !
If considered useful, I can create a method to convert a box into sphere and vice versa. With the add
method, it requires very little code.
Edited by Antoine Facchini