[go: up one dir, main page]

Fix sparse_extra_3, disable counting temporaries for testing DynamicSparseMatrix.

Antonio Sánchezrequested to merge
cantonios/eigen:sparse_extra_3 into master

Multiplication of column-major DynamicSparseMatrixes involves three temporaries:

  • two for transposing twice to sort the coefficients (ConservativeSparseSparseProduct.h:160)
  • one for a final copy assignment (SparseAssign.h:108)

The latter is avoided in an optimization for SparseMatrix.

Since DynamicSparseMatrix is deprecated in favor of SparseMatrix, it's not worth the effort to optimize further, so I simply disabled counting temporaries via a macro.

Note that due to the inclusion of sparse_product.cpp, the sparse_extra tests actually re-run all the original sparse_product tests as well.

We may want to simply drop the DynamicSparseMatrix tests altogether, which would eliminate the test duplication.

Related to #2048

Merge request reports