[go: up one dir, main page]

Remove nodetype attribute after Simplify operation

Christian Rohlfsrequested to merge
chrohlfs/inkscape:simplify-nodetype-remove into master

A fix to seemingly unreported bug: if a path has sodipodi:nodetypes attribute, after the "Simplify" operation it remains unchanged, which could lead to paradoxes like this (smooth node is not smooth at all):

smooth-node

The fix just removes the attribute after the operation by calling the item->removeAttribute("sodipodi:nodetypes") method.

Steps to reproduce the bug

  1. Open Inkscape
  2. Draw a shape with the Freehand tool
  3. Open XML Editor (Ctrl+Shift+X) to see changes
  4. With the Node tool tweak a node of the path: the sodipodi:nodetypes attribute will be added to the object
  5. Do the Simplify operation either by pressing Ctrl+L or by clicking Path->Simplify menu item

What happened?

sodipodi:nodetypes attribute remains unchanged so nodetypes are a mess.

What should have happened?

Nodetypes should be recalculated. The simplest way to achieve this is to delete the attribute right after the operation.

Inkscape Version:

This bug affects 1.2.2 and 1.3-dev Inkscape versions.

Merge request reports