[go: up one dir, main page]

chore: Accept env label in metrics submitted by ringctl / Tissue

Siddharth Kannanrequested to merge
sk/add-env-label-to-tissue-metrics into master

What does this MR do and why?

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/work_items/21219

This MR adds support for the env label in Tissue metrics submitted by ringctl. This allows metrics to be tagged with environment information (amp cluster names) for better observability.

This MR goes hand-in-hand with gitlab-com/gl-infra/ringctl!417. We should merge this MR first, and the ringctl MR soon afterwards to start submitting the env label.

(This change is not backward compatible because we can have only a single definition for a given metric, and if that value is not submitted, metric values will not be recorded. For this particular change, I think this is OK because it is very small. For other changes, it would be great to learn more about how we could make this backward compatible.)

Content

  • fix: Use default for the first parameter

  • feat: Accept env as a label for Tissue metrics

Author Check-list

  • Has documentation been updated?
Edited by Siddharth Kannan

Merge request reports