[go: up one dir, main page]

Expect environment variable named TRACKING_DEPLOYMENT_ENVIRONMENT instead of DEPLOY_ENVIRONMENT

Reuben Pereirarequested to merge
rp/rename-deploy-environment into master

What does this MR do?

Expect TRACKING_DEPLOYMENT_ENVIRONMENT instead of DEPLOY_ENVIRONMENT from deployer. This is because DEPLOY_ENVIRONMENT is used for special logic in deployer. To avoid possible errors or confusion in deployer, we use a different variable name.

The three jobs that have been changed in this MR are record_metadata_deployment, create_qa_issue, and track-deployment.

  1. record_metadata_deployment - Not used yet, so we can safely modify. Will start being used after https://ops.gitlab.net/gitlab-com/gl-infra/deployer/-/merge_requests/458 is merged.
  2. create_qa_issue - Not used yet, so we can safely modify. Will start being used after https://ops.gitlab.net/gitlab-com/gl-infra/deployer/-/merge_requests/458 is merged.
  3. track-deployment - This is currently in use, so we need to maintain backwards compatibility (just for a few days) by allowing either DEPLOY_ENVIRONMENT or TRACKING_DEPLOYMENT_ENVIRONMENT.

See discussion in https://ops.gitlab.net/gitlab-com/gl-infra/deployer/-/merge_requests/458#note_121480.

Related to gitlab-com/gl-infra/delivery#2133 (closed).

Author Check-list

  • Has documentation been updated?
Edited by Reuben Pereira

Merge request reports