[Webhooks] Migrate Trigger section to Vue
What does this MR do and why?
Where: in the webhooks settings for groups and projects
- Moves the Trigger section to new webhook_form_trigger_list.vue
- Adds the trigger_list to webhook_form_app
- Put push events directly in the form instead of letting it have its own webhook.js
- Also migrates triggers that rely on certain conditions:
- Is the group hooks form
- is enterprise only (i.e. vulnerability events)
- Updates a variety of tests because of these changes
Minimal user-facing changes. Some text is changed following the figma file.
Also, I've moved the group triggers (project, subgroups, members) to the bottom of the form with vulnerability events. Because those four are EE-only.
What is NOT covered by this MR
- custom webhook template and ssl verificaton . Will be addressed in the broader issue #513631
- Bug: After the user edits an existing hook, they aren't redirected to the list of hooks. You can see this behavior on staging / master.
- Deleting the no longer necessary haml files can go in a follow up MR
References
Screenshots or screen recordings
| Before | After |
|---|---|
| Project hook | Project hook |
|
|
| Group Hook | Group Hook |
|
|
How to set up and validate locally
- For group webhooks, you'd need to have a premium or ultimate license.
- Choose a top level group . Click settings -> webhooks -> Add a webhook.
- Attempt to change the triggers (fill out the form) and save
- Attempt to edit existing hook you just created. Note the bug #579392 (closed)
- For project webhooks. Go to a group settings page -> webhooks -> Add a webhook
- Repeat above steps
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #578783 (closed)
Edited by Oiza Baiye