Remove search_glql_fix_null_field_pagination feature flag
What does this MR do and why?
This MR removes the search_glql_fix_null_field_pagination feature flag and its associated legacy code.
The feature flag was introduced in !215945 (merged) to fix a critical bug in Elasticsearch pagination where records with null sortable field values (e.g., milestone_due_date) were completely unreachable after the first page.
The fix has been validated and is ready for general availability.
References
- Original MR: !215945 (merged)
- Rollout issue: #583611
- Original bug: #583599 (closed)
Screenshots or screen recordings
Not applicable - backend changes only.
How to set up and validate locally
-
Run the related tests to verify the changes:
bundle exec rspec ee/spec/lib/search/elastic/pagination_spec.rb ee/spec/lib/search/elastic/relation_spec.rb -
(Optional) With Elasticsearch enabled, test GLQL pagination with nullable fields:
- Create issues with and without milestones
- Use GLQL to query issues sorted by milestone
- Verify pagination works correctly through all pages
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.