[go: up one dir, main page]

Enable security manager role in test suite by default

Miki Amosrequested to merge
582641-enable-security-manager-in-tests into master

Why was this needed?

  • Enables the security manager by default in tests to match production behavior
  • Helps uncover integration issues and bugs early
  • Reduces test verbosity by eliminating repetitive mocking
  • Allows using let_it_be for better test performance

Changes included

  • Set ENV["GITLAB_SECURITY_MANAGER_ROLE"] = 'true' in spec_helper.rb
  • Add :disable_security_manager tag support for tests that need it disabled
  • Add security_manager to assignable roles in RolesHelpers
  • Update expected access levels to include SECURITY_MANAGER (25)
  • Fix GraphQL enum to handle role names with spaces (using tr)
  • Update various spec files to account for the security manager being enabled

Testing

  • All updated tests pass with the security manager enabled
  • Tests requiring disabled state use :disable_security_manager tag

Related to #582641

Merge request reports