Delete the geo_object_storage_verification feature flag
This feature flag was introduced in 16.4, which is more than 4 milestones ago.
As part of our process we want to ensure feature flags don't stay too long in the codebase.
Rollout issue: #410387 (closed)
Remaining mentions of the feature flag (click to expand)
doc/administration/geo/replication/datatypes.md
84:1. Object Storage verification is behind a [feature flag](../../feature_flags/_index.md), `geo_object_storage_verification`, [introduced in 16.4](https://gitlab.com/groups/gitlab-org/-/epics/8056) and enabled by default. It uses a checksum of the file size to verify the files.
doc/administration/geo/replication/object_storage.md
18:- Verification of files stored in object storage was [introduced](https://gitlab.com/groups/gitlab-org/-/epics/8056) in GitLab 16.4 [with a flag](../../feature_flags/_index.md) named `geo_object_storage_verification`. Enabled by default.
doc-locale/ja-jp/update/versions/gitlab_16_changes.md
561: sudo gitlab-rails runner 'Feature.disable(:geo_object_storage_verification)'
740: sudo gitlab-rails runner 'Feature.disable(:geo_object_storage_verification)'
doc/administration/geo/replication/datatypes.md
84:1. Object Storage verification is behind a [feature flag](../../feature_flags/_index.md), `geo_object_storage_verification`, [introduced in 16.4](https://gitlab.com/groups/gitlab-org/-/epics/8056) and enabled by default. It uses a checksum of the file size to verify the files.
253:> - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/410387) in GitLab 18.5. Feature flag `geo_object_storage_verification` removed.
doc/administration/geo/replication/object_storage.md
18:- Verification of files stored in object storage was [introduced](https://gitlab.com/groups/gitlab-org/-/epics/8056) in GitLab 16.4 [with a flag](../../feature_flags/_index.md) named `geo_object_storage_verification`. Enabled by default.
19:- [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/410387) in GitLab 18.5. Feature flag `geo_object_storage_verification` removed.
doc/update/versions/gitlab_16_changes.md
628: > - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/410387) in GitLab 18.5. Feature flag `geo_object_storage_verification` removed.
810: > - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/410387) in GitLab 18.5. Feature flag `geo_object_storage_verification` removed.
Currently the feature flag is enabled on production
It is possible that this MR will still need some changes to remove references to the feature flag in the code.
At the moment the gitlab-housekeeper is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues.
It is the responsibility of groupgeo to push those changes to this branch.
Note: If you do not want to remove this feature flag at this time, you can add an intended_to_rollout_by_date attribute in the feature flag YAML file to prevent automated removal.
TODO for the reviewers before merging this MR
-
See the status of the rollout by checking #410387 (closed), https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues/?search=geo_object_storage_verification&sort=created_date&state=all&label_name%5B%5D=host%3A%3Agitlab.com -
Verify the feature flag status via chatops by running /chatops run feature get geo_object_storage_verification. -
Search for references to GeoObjectStorageVerificationin frontend part of code -
Search for references to geo_object_storage_verificationin code -
Check if we need to remove any Gem or other related code by looking at the changes in !127408 (merged)
This change was generated by
gitlab-housekeeper
in CI using the Keeps::DeleteOldFeatureFlags keep.
To provide feedback on your experience with gitlab-housekeeper please create an issue with the
label GitLab Housekeeper and consider pinging the author of this keep.