Add alert to inform gitlab team members about logging - revert fix
What does this MR do and why?
Merge branch 'tbulva-duo-gitLab-logging-notice' into 'master'
feat: Add alert to inform gitlab team members about logging
See merge request !201631 (merged)
Merged-by: Jose Ivan Vargas jvargas@gitlab.com Approved-by: mo khan mo@mokhan.ca Approved-by: Ammar Alakkad aalakkad@gitlab.com Approved-by: Alper Akgun aakgun@gitlab.com Approved-by: Jose Ivan Vargas jvargas@gitlab.com Reviewed-by: Ammar Alakkad aalakkad@gitlab.com Reviewed-by: Jose Ivan Vargas jvargas@gitlab.com Reviewed-by: GitLab Duo gitlab-duo@gitlab.com Co-authored-by: Tomas Bulva tbulva@gitlab.com
(cherry picked from commit f6547f36)
51c7f50a feat: Add alert to inform gitlab team members about logging
Co-authored-by: Jose Ivan Vargas jvargas@gitlab.com
Root Cause Analysis The incident was caused by a contract mismatch in the workflow metadata handling. The API contract requires serialized JSON (string format), but the code was supplying an unserialised JSON object, leading to request unmarshalling failures across web interfaces.
Changes made to fix the issue that caused the problems:
-
Corrected the data format mismatch by ensuring workflow metadata is properly serialized to JSON string format before use in.
-
Implemented a comprehensive test suite that validates correct data types for all variables in the contract These tests will catch any future format mismatches before they reach production
-
Added inline comments in the test files with direct references to the contract specifications This ensures future developers understand the format requirements and their importance
References
relates to: https://gitlab.com/gitlab-org/gitlab/-/issues/557081
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
 |
 |
How to set up and validate locally
- setup duo locally
- apply patch showDuoAlert.patch
- open duo
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.