[go: up one dir, main page]

Update the duplicated logic to create desired config

Ashvin Sharmarequested to merge
ashvins/17483/improve-validations into master

Issue: Add a background DB migration to populate the w... (#538360 - closed)

Prerequisite knowledge

This MR is part of effort to backfill desired_config of all workspaces. A similar MR (Add files from RemoteDevelopment module for mig... (!199244 - merged) • Ashvin Sharma • 18.3) has already been merged after which a dry run exposed some of the gaps in our validation logic (mentioned here). An MR was merged which fixed those (Validate only kubernetes objects using JSON schema (!200985 - merged)) and those changes need to be copied to the migration logic. Once this MR is done another dry run will be executed and once all looks good the migration MR will be merged.

What does this MR do and why?

Update the duplicated logic to create desired config

This MR updates the files update by this MR !200985 (merged) and other MRs to ensure no mismatch during the backfill operation.

References

Parent MR: Validate only kubernetes objects using JSON schema (!200985 - merged)

How to set up and validate locally

Currently there is no way to validate it locally. This code will not be execute until !199102 (merged) is merged.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Ashvin Sharma

Merge request reports