[go: up one dir, main page]

Fix top calculations for paneled view

What does this MR do and why?

Many sticky elements calculate their top offset based on an assumption that they must take into account certain other sticky or fixed elements, like the performance bar, the top bar, and any admin banners. This is (happily) not true in the paneled layout, as these elements must only make themselves sticky relative to their parent panel and any sticky elements that should appear further up the page from them.

This can be easily achieved by setting the CSS variables for various element heights to 0px inside the panel, allowing for a baseline value of 0px that will have the heights of any other sticky elements added to it.

References

Screenshots or screen recordings

Use case Before After
markdown preview sticky header in work item (fixed) Screenshot 2025-09-30 at 15.37.43.png Screenshot 2025-09-30 at 15.38.15.png
markdown preview sticky header in MR (fixed) Screenshot 2025-09-30 at 15.40.18.png Screenshot 2025-09-30 at 15.39.58.png
Incident sticky header and markdown preview sticky header on incident page (both fixed) Screenshot 2025-09-30 at 15.36.38.png Screenshot 2025-09-30 at 15.36.19.png
todo bulk sticky header (no change but specific override code removed) Screenshot 2025-09-30 at 15.40.53.png Screenshot 2025-09-30 at 15.41.09.png
work item sticky header (no change but specific override code removed) image.png image.png
MR sticky header (no change but specific override code removed) Screenshot 2025-09-30 at 15.42.27.png Screenshot 2025-09-30 at 15.42.09.png
MR file diff sticky header and MR file tree sticky element (no change but specific override code removed) Screenshot 2025-09-30 at 15.42.48.png Screenshot 2025-09-30 at 15.43.08.png
Setting sticky header (no change but specific override code removed) Screenshot 2025-09-30 at 15.44.07.png Screenshot 2025-09-30 at 15.43.49.png
Vulnerability dashboard (no change but specific override code removed) Screenshot 2025-09-30 at 15.44.47.png Screenshot 2025-09-30 at 15.45.06.png

How to set up and validate locally

  1. Check out this branch
  2. Ensure the paneled view is turned on
  3. Visit the pages in the screenshots above

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading