[go: up one dir, main page]

Skip to content

Fork suggestion becomes a modal

What does this MR do and why?

  • uses custom GlModal instead of createAlert to specify post method on the fork button

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
fork_suggestion_before Screen_Recording_2025-03-04_at_18.36.01

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. In rails console enable the experiment fully

    Feature.enable(:blob_overflow_menu)
  2. Impersonate another user and choose a project where that user is a guest

  3. Go to Project / Repository and open any file

  4. Open the actions overflow menu and make sure Upload file and Delete file do not trigger their respective modals.

  5. Make sure the fork suggestion is rendered, dismissible and forks the project on the primary action.

  6. To compare with previous implementation disable blob_overflow_menu feature flag. Upload and Download controls will be located on the file viewer bar.

Related to #519316 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports

Loading