[go: up one dir, main page]
Skip to content

Unlink the fork relationship and close MRs while archiving the project

Emma Parkrequested to merge
518708/malicious-MR-changes into master

What does this MR do and why?

Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/518708+

What this MR aims to do:

This MR ensures that when a project is archived:

  • The fork relationship is removed.
  • All forked MRs are closed.

Changes

  • Call UnlinkForkService when a project is archived (behind a feature flag).
  • Allow MergeRequests::CloseService to bypass permission checks if the project is archived and a new skip_authorization param is set.
  • Add feature flag: destroy_fork_network_on_archive.
  • Add specs for archiving and MR closing behaviour.

Screenshots or screen recordings

with destroy_fork_network_on_archive FF disabled with destroy_fork_network_on_archive FF enabled
FF disabled FF enabled

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Emma Park

Merge request reports