[go: up one dir, main page]
Skip to content

Update MR list label filter name to fix negatable filtering

Thomas Randolphrequested to merge
tor/defect/gql-label-filter-name-mismatch into master

What does this MR do and why?

For #508334 (closed)

In !155839 (diffs), the name for the label field was updated from labels to label_name.

The rest of the implementation (shared with Plan/Issues) uses label_name, so our (Code Review) use of it is the only thing that can change.

Unfortunately, this means that the negatable value - labels - no longer works, because every other filter implementation is using label_name.

This changes the negatable filter to use the non-deprecated parameter name, which re-enables label negation in the MR list page.

Unfortunately (again), other products (like analytics) also use this query, so I've had to also update those key names.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  • Try to filter for != a label on the MR page
  • Bonus: Also filter for labels (both = and !=) on the Issues list page, since this shares back end implementation
Edited by Thomas Randolph

Merge request reports