[go: up one dir, main page]

Skip to content

Insert backtick around @ username mentions in BB Server Importer

What does this MR do and why?

This change adds backticks around @ username mentions in BB Server descriptions and comments.

It prevents linking to incorrect users in imported descriptions and comments (see image below) and aligns the BB Server importer with behavior in other importers.

The unused :bitbucket_server_convert_mentions_to_users feature flag, and code behind this flag, has also been removed as users will not be mapped with the nre user contributions mapping feature.

link-example

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
before after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Set up a BBServer instance locally with docker using these instructions
  2. Visit http://localhost:7990/login?nextUrl=%2Fdashboard
  3. Create a repository, add a pull request, add some comments to the PR that include @ mentions
  4. create an api access token
  5. pull the gdk branch and start the gdk
  6. visit project > new > import > bitbucket server
  7. add BB credentials and initiate an import of the repository
  8. when import is finished visit relevant MR and observe @ mentions are surrounded by backticks

Related to #477554 (closed)

Edited by Carla Drago

Merge request reports

Loading