[go: up one dir, main page]

Skip to content

Design for consistent commenting loading states

Problem

In gitlab-design#1608 (closed) we identified a number of things that can be done to improve the perceived performance (particularly in MRs). One area that showed a lot of issues was commenting:

  1. Regular commenting
  2. Replying to a thread
  3. Adding a review comment (specific to MRs)
  4. Editing a published comment
  5. Editing a pending comment (specific to MRs)

These inconsistencies seem to affect not only MRs, but also issues and epics.

In the following videos, notice how the comments appear/disappear, appear temporarily duplicated, or the text area becomes disabled inconsistently.

CleanShot_20210513112517

CleanShot_20210513113321

CleanShot_20210513113555

CleanShot_20210513113009

Proposal

Unify commenting loading states

Edited by Annabel Dunstone Gray