[go: up one dir, main page]
Skip to content

refactor: enforce 'no-shadow' eslint rule

Jérémie Piellardrequested to merge
piellardj/giro3d:639-eslint-no-shadow into main

Closes #639 (closed)

This MR enforces the `no-shadow' eslint rule. To do so I:

  • added it in the eslint config file
  • modified the code everywhere there was a variable shadowing issue. I did so in three ways:
    • sometimes I just used the vscde rename tool (F2) to rename either the "higher-scoped" variable or the "localest-scoped" variable. This is safe.
    • sometimes I removed a function's argument when this argument had the same name as a global variable, and the function was always called with this global variable as argument.
    • in PickPointsAt.ts, it is a bit more subtle and fixes a small bug introduced by 2dd0dc14
Edited by Jérémie Piellard

Merge request reports