[go: up one dir, main page]

feat: subcontracting inward by mihir-kandoi [frappe] PR#47728

Bot Dokosrequested to merge
ft-pr-47728 into develop

From: https://github.com/frappe/erpnext/pull/47728
Date: 2025-10-14 15:00:49+05:30

  • feat: subcontracting inward (#47728)


Diagnostics

pre-commit failed for source commit: f2b948a483ebc1d2938898ccba4588b4c956d64d
erpnext/controllers/subcontracting_controller.py:27:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/controllers/subcontracting_controller.py:76:9: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/controllers/subcontracting_controller.py:110:6: F811 Redefinition of unused `set_valuation_rate_for_rm` from line 78
erpnext/controllers/subcontracting_controller.py:1492:6: B007 Loop control variable `key` not used within loop body
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:250:52: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:493:34: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:583:10: UP030 Use implicit references for positional format fields
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:651:44: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:742:76: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:765:89: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:816:57: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:888:85: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:914:83: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1017:79: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1512:17: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1718:16: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1719:14: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1720:21: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1722:19: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1723:26: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1724:12: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1770:21: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py:1771:10: RUF013 PEP 484 prohibits implicit `Optional`
erpnext/stock/doctype/warehouse/warehouse.py:232:9: RUF005 Consider `[*children, warehouse]` instead of concatenation
Found 24 errors.
No fixes available (22 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-47728

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-47728

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports