[go: up one dir, main page]

fix(test): incorrect linter changes on test_gross_profit.py by ruff by ruthra-kumar [frappe] PR#42339

From: https://github.com/frappe/erpnext/pull/42339
Date: 2024-07-15 15:52:59+05:30

  • fix(test): incorrect ruff changes
  • fix(test): incorrect linter fix from ruff



Diagnostics

pre-commit failed for source commit: 40cebf257bfdd51cb50e9f62d358dd9a1e287425
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

erpnext/accounts/report/gross_profit/test_gross_profit.py:92:16: B008 Do not perform function call `nowdate` in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
erpnext/accounts/report/gross_profit/test_gross_profit.py:94:25: RUF100 [*] Unused blanket `noqa` directive
Found 2 errors.
[*] 1 fixable with the `--fix` option.


pre-commit failed for source commit: fde348c8a0bf534f3742fdc243928706dcc4eef4
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

erpnext/accounts/report/gross_profit/test_gross_profit.py:92:16: B008 Do not perform function call `nowdate` in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
erpnext/accounts/report/gross_profit/test_gross_profit.py:94:25: RUF100 [*] Unused blanket `noqa` directive
Found 2 errors.
[*] 1 fixable with the `--fix` option.



Checkout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-42339

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-42339

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports

Loading