[go: up one dir, main page]

perf: dont run queries unnecessarily, improved filters by sagarvora [frappe] PR#41993

Bot Dokosrequested to merge
ft-pr-41993 into develop

From: https://github.com/frappe/erpnext/pull/41993
Date: 2024-06-22 21:27:00+05:30

  • perf: dont run queries unnecessarily, improved filters (#41993)


Diagnostics

pre-commit failed for source commit: ac6d85aed628734820cc055d00e062b4fd90bb8c
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

erpnext/controllers/subcontracting_controller.py:24:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/controllers/subcontracting_controller.py:56:9: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/controllers/subcontracting_controller.py:1237:6: B007 Loop control variable `key` not used within loop body
Found 3 errors.
No fixes available (3 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-41993

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-41993

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports