[go: up one dir, main page]

fix: multiple issues related to serial and batch bundle by rohitwaghchaure [frappe] PR#41662

Bot Dokosrequested to merge
ft-pr-41662 into develop

From: https://github.com/frappe/erpnext/pull/41662
Date: 2024-05-28 18:48:09+05:30

  • fix: multiple issues related to serial and batch bundle (#41662)


Diagnostics

pre-commit failed for source commit: ce834f5dba1066b59705eb171e1bca331405b704
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

erpnext/accounts/doctype/pos_invoice/pos_invoice.py:186:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/pos_invoice/pos_invoice.py:332:27: F841 Local variable `qty` is assigned to but never used
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:233:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:250:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:270:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:364:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:405:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:453:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:719:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:953:6: F841 Local variable `asset_category` is assigned to but never used
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py:1554:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/sales_invoice/sales_invoice.py:242:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/sales_invoice/sales_invoice.py:279:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/sales_invoice/sales_invoice.py:566:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/sales_invoice/sales_invoice.py:717:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/sales_invoice/sales_invoice.py:943:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/sales_invoice/sales_invoice.py:1042:8: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/accounts/doctype/sales_invoice/sales_invoice.py:1444:23: UP008 Use `super()` instead of `super(__class__, self)`
erpnext/stock/doctype/delivery_note/test_delivery_note.py:72:3: F841 Local variable `company` is assigned to but never used
erpnext/stock/doctype/delivery_note/test_delivery_note.py:96:3: F841 Local variable `company` is assigned to but never used
erpnext/stock/doctype/delivery_note/test_delivery_note.py:143:7: B007 Loop control variable `i` not used within loop body
erpnext/stock/doctype/delivery_note/test_delivery_note.py:880:7: B007 Loop control variable `i` not used within loop body
erpnext/stock/doctype/delivery_note/test_delivery_note.py:1103:7: B007 Loop control variable `i` not used within loop body
erpnext/stock/doctype/delivery_note/test_delivery_note.py:1132:7: B007 Loop control variable `i` not used within loop body
erpnext/stock/report/batch_wise_balance_history/batch_wise_balance_history.py:81:3: RUF005 Consider iterable unpacking instead of concatenation
Found 25 errors.
No fixes available (25 hidden fixes can be enabled with the `--unsafe-fixes` option).

Run ruff formatter.......................................................Failed
- hook id: ruff-format
- files were modified by this hook

5 files reformatted, 15 files left unchanged


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-41662

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-41662

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports