fix(query): don't allow using Document as a filter value by akhilnarang [frappe] PR#34823

From: https://github.com/frappe/frappe/pull/34823
Date: 2025-11-24 11:13:43+05:30

• fix(query): don't allow using Document as a filter value (#34823)

---

Diagnostics

pre-commit failed for source commit: bd044e520c1b6b78ceeb62da2d39376ebcecd4c9
warning: The following rules have been removed and ignoring them has no effect:
    - UP038

RUF005 Consider `[*self.fields, "parent", "parentfield"]` instead of concatenation
    --> frappe/database/query.py:1791:11
     |
1789 |         return frappe.qb.get_query(
1790 |             self.doctype,
1791 |             fields=self.fields + ["parent", "parentfield"],
     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1792 |             filters=filters,
1793 |             order_by="idx asc",
     |
help: Replace with `[*self.fields, "parent", "parentfield"]`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

---

Checkout instructions

# Checkout locally
git fetch upstream
git switch ft-pr-34823

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-34823

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease