Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to the dev.cc branch of
https://dvyukov%40google.com@code.google.com/p/go/

Typo in subject.


On Fri, Dec 5, 2014 at 10:31 AM, dvyukov via golang-codereviews <
golang-codereviews@googlegroups.com> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to the dev.cc branch of
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> cnd/go: add tracing support
> cmd/go part of tracing functionality:
> https://docs.google.com/document/u/1/d/1FP5apqzBgr7ahCCgFO-
> yoVhk4YZrNIDNf9RybngBc14/pub
> Full change:
> https://codereview.appspot.com/146920043
>
> Please review this at https://codereview.appspot.com/182330044/
>
> Affected files (+11, -1 lines):
>   M src/cmd/go/doc.go
>   M src/cmd/go/test.go
>   M src/cmd/go/testflag.go
>
>
> Index: src/cmd/go/doc.go
> ===================================================================
> --- a/src/cmd/go/doc.go
> +++ b/src/cmd/go/doc.go
> @@ -1040,6 +1040,10 @@
>         -timeout t
>             If a test runs longer than t, panic.
>
> +       -trace trace.out
> +           Write an execution trace to the specified file before exiting.
> +           Writes test binary as -c would.
> +
>         -v
>             Verbose output: log all tests as they are run. Also print all
>             text from Log and Logf calls even if the test succeeds.
> Index: src/cmd/go/test.go
> ===================================================================
> --- a/src/cmd/go/test.go
> +++ b/src/cmd/go/test.go
> @@ -206,6 +206,10 @@
>         -timeout t
>             If a test runs longer than t, panic.
>
> +       -trace trace.out
> +           Write an execution trace to the specified file before exiting.
> +           Writes test binary as -c would.
> +
>         -v
>             Verbose output: log all tests as they are run. Also print all
>             text from Log and Logf calls even if the test succeeds.
> Index: src/cmd/go/testflag.go
> ===================================================================
> --- a/src/cmd/go/testflag.go
> +++ b/src/cmd/go/testflag.go
> @@ -42,6 +42,7 @@
>    -run="": passes -test.run to test
>    -short=false: passes -test.short to test
>    -timeout=0: passes -test.timeout to test
> +  -trace="": passes -test.trace to test
>    -v=false: passes -test.v to test
>  `
>
> @@ -103,6 +104,7 @@
>         {name: "run", passToTest: true},
>         {name: "short", boolVar: new(bool), passToTest: true},
>         {name: "timeout", passToTest: true},
> +       {name: "trace", passToTest: true},
>         {name: "v", boolVar: &testV, passToTest: true},
>  }
>
> @@ -192,7 +194,7 @@
>                         testBench = true
>                 case "timeout":
>                         testTimeout = value
> -               case "blockprofile", "cpuprofile", "memprofile":
> +               case "blockprofile", "cpuprofile", "memprofile", "trace":
>                         testProfile = true
>                         testNeedBinary = true
>                 case "coverpkg":
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

fixed

On Fri, Dec 5, 2014 at 9:41 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Typo in subject.
>
>
> On Fri, Dec 5, 2014 at 10:31 AM, dvyukov via golang-codereviews
> <golang-codereviews@googlegroups.com> wrote:
>>
>> Reviewers: rsc,
>>
>> Message:
>> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>>
>> I'd like you to review this change to the dev.cc branch of
>> https://dvyukov%40google.com@code.google.com/p/go/
>>
>>
>> Description:
>> cnd/go: add tracing support
>> cmd/go part of tracing functionality:
>>
>>
https://docs.google.com/document/u/1/d/1FP5apqzBgr7ahCCgFO-yoVhk4YZrNIDNf9Ryb...
>> Full change:
>> https://codereview.appspot.com/146920043
>>
>> Please review this at https://codereview.appspot.com/182330044/
>>
>> Affected files (+11, -1 lines):
>>   M src/cmd/go/doc.go
>>   M src/cmd/go/test.go
>>   M src/cmd/go/testflag.go
>>
>>
>> Index: src/cmd/go/doc.go
>> ===================================================================
>> --- a/src/cmd/go/doc.go
>> +++ b/src/cmd/go/doc.go
>> @@ -1040,6 +1040,10 @@
>>         -timeout t
>>             If a test runs longer than t, panic.
>>
>> +       -trace trace.out
>> +           Write an execution trace to the specified file before exiting.
>> +           Writes test binary as -c would.
>> +
>>         -v
>>             Verbose output: log all tests as they are run. Also print all
>>             text from Log and Logf calls even if the test succeeds.
>> Index: src/cmd/go/test.go
>> ===================================================================
>> --- a/src/cmd/go/test.go
>> +++ b/src/cmd/go/test.go
>> @@ -206,6 +206,10 @@
>>         -timeout t
>>             If a test runs longer than t, panic.
>>
>> +       -trace trace.out
>> +           Write an execution trace to the specified file before exiting.
>> +           Writes test binary as -c would.
>> +
>>         -v
>>             Verbose output: log all tests as they are run. Also print all
>>             text from Log and Logf calls even if the test succeeds.
>> Index: src/cmd/go/testflag.go
>> ===================================================================
>> --- a/src/cmd/go/testflag.go
>> +++ b/src/cmd/go/testflag.go
>> @@ -42,6 +42,7 @@
>>    -run="": passes -test.run to test
>>    -short=false: passes -test.short to test
>>    -timeout=0: passes -test.timeout to test
>> +  -trace="": passes -test.trace to test
>>    -v=false: passes -test.v to test
>>  `
>>
>> @@ -103,6 +104,7 @@
>>         {name: "run", passToTest: true},
>>         {name: "short", boolVar: new(bool), passToTest: true},
>>         {name: "timeout", passToTest: true},
>> +       {name: "trace", passToTest: true},
>>         {name: "v", boolVar: &testV, passToTest: true},
>>  }
>>
>> @@ -192,7 +194,7 @@
>>                         testBench = true
>>                 case "timeout":
>>                         testTimeout = value
>> -               case "blockprofile", "cpuprofile", "memprofile":
>> +               case "blockprofile", "cpuprofile", "memprofile", "trace":
>>                         testProfile = true
>>                         testNeedBinary = true
>>                 case "coverpkg":
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/182330044 is best) in the description in your
new CL.

Thanks very much.