[go: up one dir, main page]
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(557)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 166660043: [dev.cc] runtime: convert plan9 to Go

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by 0intro
Modified:
11 years, 2 months ago
Reviewers:
mischief, rsc
Visibility:
Public.

Description

runtime: convert plan9 to Go This is an experimental change. Please don't submit.

Patch Set 1 #

Patch Set 2 : diff -r c86fc52684d634fe8b43f2e8eda07e4a8341c07a https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 723ca3789b88b81c6187ccf8d07c7dae3240e200 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 1eba16f9db2aaba407d0f413acf0c537273259d4 https://code.google.com/p/go #

Patch Set 5 : diff -r b6898620a286e97193b9519b2a9ba7e6ddded0a1 https://code.google.com/p/go #

Patch Set 6 : diff -r b6898620a286e97193b9519b2a9ba7e6ddded0a1 https://code.google.com/p/go #

Patch Set 7 : diff -r ea6dd49d5e427c9c3cb53ecb11a755e322e83050 https://code.google.com/p/go #

Patch Set 8 : diff -r 6c4f729d69500e422cfd1ef81af3cfce7f73137e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -731 lines) Patch
M src/runtime/defs_plan9_386.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/defs_plan9_amd64.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/env_plan9.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/mem_plan9.go View 1 2 1 chunk +41 lines, -92 lines 0 comments Download
M src/runtime/netpoll_stub.go View 1 1 chunk +3 lines, -6 lines 0 comments Download
M src/runtime/os1_plan9.go View 1 2 3 4 5 6 7 1 chunk +191 lines, -283 lines 0 comments Download
M src/runtime/os2_plan9.go View 1 1 chunk +60 lines, -81 lines 0 comments Download
M src/runtime/os_plan9.go View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M src/runtime/os_plan9_386.go View 1 2 3 4 5 6 1 chunk +96 lines, -114 lines 0 comments Download
M src/runtime/os_plan9_amd64.go View 1 2 3 4 5 6 1 chunk +104 lines, -122 lines 0 comments Download
M src/runtime/signal_plan9.go View 1 2 3 4 1 chunk +24 lines, -33 lines 0 comments Download
M src/runtime/stubs2.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/runtime/stubs3.go View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mischief
https://codereview.appspot.com/166660043/diff/260002/src/runtime/mem_plan9.go File src/runtime/mem_plan9.go (right): https://codereview.appspot.com/166660043/diff/260002/src/runtime/mem_plan9.go#newcode9 src/runtime/mem_plan9.go:9: var bloc = uintptr(unsafe.Pointer(&end)) it seems that this turns ...
11 years, 2 months ago (2014-11-15 02:31:14 UTC) #1
0intro
https://codereview.appspot.com/166660043/diff/260002/src/runtime/mem_plan9.go File src/runtime/mem_plan9.go (right): https://codereview.appspot.com/166660043/diff/260002/src/runtime/mem_plan9.go#newcode9 src/runtime/mem_plan9.go:9: var bloc = uintptr(unsafe.Pointer(&end)) The bloc variable should be ...
11 years, 2 months ago (2014-11-15 09:35:31 UTC) #2
0intro
https://codereview.appspot.com/166660043/diff/260002/src/runtime/mem_plan9.go File src/runtime/mem_plan9.go (right): https://codereview.appspot.com/166660043/diff/260002/src/runtime/mem_plan9.go#newcode9 src/runtime/mem_plan9.go:9: var bloc = uintptr(unsafe.Pointer(&end)) The bloc variable should be ...
11 years, 2 months ago (2014-11-15 09:35:32 UTC) #3
rsc
https://codereview.appspot.com/166660043/diff/490001/src/runtime/os_plan9.go File src/runtime/os_plan9.go (right): https://codereview.appspot.com/166660043/diff/490001/src/runtime/os_plan9.go#newcode16 src/runtime/os_plan9.go:16: func seek(fd int32, offset int64, whence int32) int64 go:noescape ...
11 years, 2 months ago (2014-11-16 21:43:53 UTC) #4
0intro
11 years, 2 months ago (2014-11-16 22:51:51 UTC) #5 
https://codereview.appspot.com/166660043/diff/490001/src/runtime/os_plan9.go
File src/runtime/os_plan9.go (right):

https://codereview.appspot.com/166660043/diff/490001/src/runtime/os_plan9.go#...
src/runtime/os_plan9.go:16: func seek(fd int32, offset int64, whence int32)
int64
On 2014/11/16 21:43:53, rsc wrote:
> go:noescape is meaningless on functions that don't take pointers.
> seek, sleep, rfork, noted, setfpmasks, errstr

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b