Issue 160058: Verify git and git-svn are 1.6 or later.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 160058: Verify git and git-svn are 1.6 or later.

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 2 months ago by chase

Modified:
16 years, 2 months ago

Reviewers:
evan

Visibility:
Public.

Description

Verify git-svn is 1.6 or later. BUG=none TEST=git-cl shows an error when run on a system with git < 1.6.

Patch Set 2 : only check git-svn when calling GetIsGitSvn #

Patch Set 3 : remove git 1.6 version check #

Patch Set 4 : no unit test no more #

Total comments: 2

Patch Set 5 : address comments #

Created: 16 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	git-cl	View	1 2 3 4	3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

evan

http://codereview.appspot.com/160058/diff/1/2 File git-cl (right): http://codereview.appspot.com/160058/diff/1/2#newcode65 git-cl:65: self.VerifyGitSvnVersion() Can you only check these if we start ...

16 years, 2 months ago (2009-11-24 23:00:06 UTC) #1

chase

16 years, 2 months ago (2009-11-24 23:07:10 UTC) #2

evan

http://codereview.appspot.com/160058/diff/1008/1009 File git-cl (right): http://codereview.appspot.com/160058/diff/1008/1009#newcode67 git-cl:67: m = re.match(r'^git-svn version (\d+)\.(\d+)\.(\S*) \([^\)]+\)', Can you use ...

16 years, 2 months ago (2009-11-25 01:23:49 UTC) #4

chase

16 years, 2 months ago (2009-11-25 01:30:47 UTC) #5

thanks, pushed

Expand All Messages | Collapse All Messages