Issues for rog - Code Review

Issues for rog

Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
Incoming reviews (100)
	99670044	Add output for ensure-availability command.	domas	mp+221549, fwereade, rog	14		3 years, 2 months
	8731044	code review 8731044: go.net/websocket: allow server configurable	ukai	johan.bilien, shurcool, mikio, songofacandy, everton.marques, rog	8		10 years, 10 months
	102920048	state/*: login to /ENVUUID/api URLs	jameinel	hduran, mp+221632, rog	18		11 years, 7 months
	92700044	Base utils tests on IsolationSuite.	frankban	mp+221377, fwereade, rog	16		11 years, 7 months
	98510043	Move osenv.(Set)Home functions to utils.	frankban	mp+220811, fwereade, rog	3		11 years, 8 months
	100740044	Update the github.com/juju/testing dependency.	frankban	mp+220772, rog			11 years, 8 months
	95550046	Remove juju-core dependencies from filetesting.	frankban	mp+220660, rog	10		11 years, 8 months
	99180044	utils/registry: TypedNameVersion registry	jameinel	mp+219161, fwereade, rog	6		11 years, 8 months
	98480046	worker: fix simpleworker Kill	axw	mp+220563, wallyworld, rog	1		11 years, 8 months
	92920043	refactor to remove apiRootForEntity	natefinch	mp+217836, fwereade, rog			11 years, 8 months
	90160044	cmd/juju/ensureavailability: default to 3 servers	jameinel	mp+216706, axw, wallyworld, rog	1		11 years, 9 months
	88790043	HA: upgrade upstart and initiate replset	axw	mp+216245, rog	4		11 years, 9 months
	87760057	change status to show voting status	natefinch	mp+216377, rog			11 years, 9 months
	88470043	state/api: save the connection as the first addr	jameinel	axw, mp+216091, rog	2		11 years, 9 months
	87570043	agent/mongo: log version of mongo	jameinel	natefinch, mp+215656, rog	7		11 years, 9 months
	88200043	a few small HA tweaks	natefinch	mp+215924, rog	13		11 years, 9 months
	87540043	state: Use APIHostPorts to implement APIAddresses	gz	mp+215643, rog	1		11 years, 9 months
	86920043	mongo keyfiles and refactoring	natefinch	dimitern, mp+215464, axw, jameinel, rog	66		11 years, 9 months
	88030043	Ensure state server has Mongo admin rights	axw	mp+215821, rog	7		11 years, 9 months
	85570045	Fix the limit for the debug-log calls.	thumper	axw, mp+215333, rog	9		11 years, 9 months
	86490043	state: (demote)promote (un)available state servers	axw	mp+215172, rog	17		11 years, 9 months
	85590044	Various address logic fixes	axw	gz, mp+215085, rog	19		11 years, 9 months
	85850043	Add the debug-log client api	thumper	rog, jameinel, mp+214875	65		11 years, 9 months
	86400043	Fix LP 1299958	dave	mp+215107, rog	3		11 years, 9 months
	85970044	clone session in replicaset.Initiate	natefinch	mp+214990, jameinel, rog			11 years, 9 months
	72500043	MachineAgent using EnsureMongoServer	natefinch	wwitzel3, jameinel, axw, mp+209954, rog	81		11 years, 9 months
	81980043	support mongo namespaces	natefinch	mp+213334, jameinel, rog	20		11 years, 9 months
	84430044	mock_test server uses fixed order	dave	mp+214170, thumper, rog			11 years, 9 months
	82280045	Changed timeout on mongo wait after restore	hduran	mp+214118, natefinch, rog	2		11 years, 9 months
	80540043	testing/filetesting: new package	fwereade	mp+212811, rog	17		11 years, 9 months
	73910043	provider/azure: enable load-balancing/availability	axw	mp+210353, thumper, fwereade, rog	34		11 years, 9 months
	83130045	worker/peergrouper: use mongo.SelectPeerHostPort	wwitzel	wwitzel3, mp+213871, rog	4		11 years, 9 months
	83150043	state/api/agent: added IsMaster to the API	wwitzel	mp+213635, wwitzel3, hduran, rog	29		11 years, 9 months
	82960044	agent/agent: add StateServingInfo to config	mfoord	mp+212874, rog	13		11 years, 9 months
	83270045	Disable --keyFile in mongo upstart config	axw	mp+213786, fwereade, rog			11 years, 9 months
	83500043	Introduce worker/apiaddressupdater	axw	mp+213778, rog	6		11 years, 9 months
	83060044	Fix revid in dependencies.tsv for gomaasapi r48	gz	mp+213690, rog			11 years, 9 months
	75600044	Preliminary support for basic juju id commands:	mattyw	mp+210962, fwereade, rog	78		11 years, 9 months
	83050045	Generate/set state serving info	axw	mp+213610, rog	4		11 years, 9 months
	82900045	state/api: fixes to parallel api.Open	axw	mp+213569, fwereade, rog	5		11 years, 9 months
	82450043	state/api: dial info.Addrs in parallel	axw	dimitern, jameinel, mp+213401, rog	16		11 years, 9 months
	82490043	Update LP 1299958	dave	mp+213408, rog	1		11 years, 9 months
	82390045	unit.SetAddress now takes a vararg	dave	mp+213393, rog			11 years, 9 months
	82550043	agent/mongo: added MongoSelectPeerAddress	wwitzel	wwitzel3, mp+213435, rog	9		11 years, 9 months
	82500044	Initialise APIHostPorts during bootstrap	axw	mp+213483, rog			11 years, 9 months
	81780043	Cache API server addresses in .jenv	axw	mp+213217, rog	25		11 years, 9 months
	81550047	replicaset: implement MasterHostPort	wwitzel	mp+213313, rog			11 years, 10 months
	81570045	cleanup: fixing go vet warnings	wwitzel	wwitzel3, mp+213235, rog	2		11 years, 10 months
	81700043	ensure-availability command	axw	mp+213190, rog	12		11 years, 10 months
	81850043	api/agent: StateServingInfo API	mfoord	mp+213125, rog	2		11 years, 10 months
	81330044	instance: make NewAddresses take a vararg	dave	mp+213208, rog			11 years, 10 months
	81340045	Introduce APIHostPorts client API	axw	mp+213200, rog			11 years, 10 months
	81440043	state: store and retrieve StateServingInfo doc	mfoord	mp+212901, jameinel, rog	1		11 years, 10 months
	78870043	Fix:#1295650 Failproofed rsyslog restoring script	hduran	mp+212207, axw, rog	8		11 years, 10 months
	77500045	Removes to-be logged passwords.	jwharshaw	mp+211655, fwereade, rog	3		11 years, 10 months
	77420043	Add more info to the mega-watcher for machines.	frankban	mp+211527, rog	22		11 years, 10 months
	78320043	Increment juju to 1.17.7.	curtis	mp+211999, rog			11 years, 10 months
	77890045	Fix maas bridge-utils installation	axw	wwitzel3, mp+211886, rog	4		11 years, 10 months
	76120044	cmd/juju/machine: Enable GOMAXPROCS(NumCPU)	jameinel	mp+211261, rog	20		11 years, 10 months
	75990043	Dump cloud-init-output.log on failed bootstrap	axw	mp+211016, rog	6		11 years, 10 months
	74350043	Feedback HTTP service errors to AddCharm RPC call.	cmars	mp+210524, cmars_, mattyw, fwereade, rog	8		11 years, 10 months
	72270044	lxc: Fixed target-release issue precise/maas	wwitzel	wwitzel3, natefinch, mp+209974, gz, dimitern, rog	30		11 years, 10 months
	74900044	worker/instancepoller: batch instancepoller	fuzzyman	mp+209966, rog, natefinch, mfoord	30		11 years, 10 months
	61620043	Started working on add/remove user support	mattyw	mp+205593, dimitern, fwereade, rog	96		11 years, 10 months
	71490045	cmd/juju: warn about existing jenv file	fuzzyman	wwitzel3, jameinel, mp+209421, mfoord, fwereade, dimitern, rog	11		11 years, 10 months
	49960047	charm: add Bundle.Manifest	fwereade	mp+201811, frankban, rog, dimitern	20		11 years, 10 months
	69400043	uniter/charm: make Deployer an interface	fwereade	mp+208622, wallyworld, rog	9		11 years, 10 months
	69600043	mongo stuff to agent/mongod, add EnsureMongoServer	natefinch	mp+208688, wallyworld, rog	38		11 years, 10 months
	48310043	code review 48310043: os/fsnotify: API sketch	rsc	minux1, nathany, rog, iant, golang-codereviews, cespare, dave, dsymonds, howeyc, aram, brainman, chressie1, kevlar, r	27		11 years, 10 months
	69110043	utils/zip: new package	fwereade	mp+208327, dimitern, rog	45		11 years, 10 months
	39320043	GoJoyent - Wrapper for Joyent Cloud API	dstroppa	mp+198234, rog	139		11 years, 11 months
	67080043	Simpleworker implemention	natefinch	mp+207725, rog	4		11 years, 11 months
	65460043	add PatchPath method	natefinch	dimitern, mp+206984, rog	6		11 years, 11 months
	58510045	debug-log: added new debug log api and command	mue	dimitern, mp+203955, fwereade, rog	126		11 years, 11 months
	64890044	state: Make unit ids unique. Fix #1174610	dimitern	mp+206765, fwereade, rog			11 years, 11 months
	63710044	uniter: fix intermittent failure	fwereade	mp+206353, william.reade, jameinel, rog	4		11 years, 11 months
	64000043	Run unit-tests on trusty	curtis	mp+206503, rog			11 years, 11 months
	57710043	uniter: restore ability to read removed units	fwereade	mp+203505, dimitern, rog	3		11 years, 11 months
	57700044	voyeur package	natefinch	dimitern, mp+205379, rog	42		11 years, 11 months
	49640050	provider/local: always use filestorage on CLI	axw	mp+204169, thumper, rog	7		11 years, 11 months
	59560043	cmd/juju: delete .jenv if bootstrap fails	axw	dimitern, mp+204421, wallyworld, rog	4		11 years, 11 months
	60650043	state/apiserver: tag() for disconnect	jameinel	mp+205172, rog			11 years, 11 months
	59520044	Expanded variables	waigani	mp+204412, wallyworld, rog	7		11 years, 11 months
	59930043	Add errgo as a dep, and start using it.	thumper	mp+204604, william.reade, rog	1		11 years, 11 months
	59050044	Increment juju to 1.17.3.	curtis	mp+204268, rog			11 years, 11 months
	58260044	Fix dependencies.tsv	curtis	gz, mp+203757, rog			11 years, 11 months
	57740043	provisioner: fix safe-mode tests	fwereade	mp+203537, rog			11 years, 12 months
	53220043	EnsureMongoServer function for MachineAgent	natefinch	mp+201961, fwereade, rog	6		11 years, 12 months
	54950046	jujud: NotProvisioned only fatal on login	fwereade	mp+203559, rog	2		11 years, 12 months
	56020043	cmd/juju/destroyenvironment: allow -e flag	jameinel	mp+202838, fwereade, rog	6		11 years, 12 months
	53040043	ProvisioningScript client API	axw	dimitern, hazmat, mp+201893, rog	16		12 years
	49470047	fix git tests for git 1.8.5	natefinch	mp+201162, fwereade, rog	3		12 years
	49710043	utils/ssh: platform-independent KeyFingerprint	axw	mp+200980, rog, thumper, wallyworld, hanwenn	7		12 years
	49290043	Expose some more data from replica sets	natefinch	mp+200926, rog	18		12 years
	48120043	Fix incorrect whitespace in dependencies.tsv	gz	mp+200562, rog			12 years
	43730044	Create a system ssh identity on bootstrap	thumper	axw, mp+199572, rog	25		12 years
	46690044	Add PPA only for series before saucy	abentley-home	mp+200417, rog	1		12 years
	34660045	move replicaset to root directory	natefinch	dimitern, mp+199832, rog			12 years, 1 month
	35790047	mongo replicaset configuration	natefinch	mp+197916, jameinel, fwereade, rog	37		12 years, 1 month
	38240043	Introduce BootstrapContext	axw	mp+197999, fwereade, rog	23		12 years, 1 month
Outgoing reviews (97)
Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
	6567067	cmd/jujud: allow for a clean exit	rog	niemeyer, mp+126980, jayngrace666	7		1 year, 1 month
	230460044	do not use go get to fetch new repositories	rog	mattyw, mp+258017, martin.hilton	10		10 years, 8 months
	223390043	pkgrepo: new package	rog	frankban, martin.hilton, mp+255866			10 years, 9 months
	197110043	allow updating dependencies from multiple files	rog	sinzui.is, mp+247684, mattyw	6		10 years, 12 months
	199070043	merge updates from Go tree	rog	jay.wren, mp+247632, martin.hilton			10 years, 12 months
	106250043	godeps: fix fetch bug	rog	mp+224873			11 years, 6 months
	99670045	testing/testbase: remove	rog	wwitzel3, frankban, mp+221560	18		11 years, 7 months
	103780043	lxc: use testing.IsolationSuite	rog	mp+221732			11 years, 7 months
	100730044	utils/apt: new package	rog	mp+220792, natefinch			11 years, 8 months
	97670044	all: sort imports	rog	natefinch, mp+220789			11 years, 8 months
	89660043	various: fix error DeepEquals comparisons	rog	mp+216540, fwereade			11 years, 9 months
	87860047	cmd/jujud: enable HA	rog	gz, natefinch, mp+216362			11 years, 9 months
	88000050	worker/peergrouper: maintain HasVote better	rog	dimitern, mp+216359, gz	8		11 years, 9 months
	88490043	cmd/jujud: MachineWithCharmsSuite fix	rog	mp+216105, natefinch			11 years, 9 months
	88160049	update dependencies.tsv	rog	gz, mp+216099	1		11 years, 9 months
	88430044	state: StateServingInfo validity check	rog	jameinel, mp+216065			11 years, 9 months
	88130047	state/statecmd: remove	rog	mp+216053, natefinch			11 years, 9 months
	88130044	worker/uniter: fix bad use of ErrorContextf	rog	jameinel, mp+215874			11 years, 9 months
	88080043	state: chattier EnsureAvailability	rog	axw, mp+215832, natefinch	2		11 years, 9 months
	87560044	cmd/juju: destroy-environment api connect fix	rog	dimitern, mp+215697	1		11 years, 9 months
	87010044	cert: use strings not []byte	rog	natefinch, mp+215478			11 years, 9 months
	86200043	cmd/jujud: wrap singular workers	rog	mp+215035, natefinch	4		11 years, 9 months
	85600044	worker/peergrouper: back off retries	rog	mp+215054, natefinch			11 years, 9 months
	86080043	cmd/jujud: call SetAPIHostPorts in tests	rog	dimitern, mp+214971	1		11 years, 9 months
	85450044	cmd/jujud: upgradeWorker opens state	rog	dimitern, mp+214798, gz			11 years, 9 months
	84540044	state/apiserver: connection dies when State dead	rog	dimitern, mp+214303	10		11 years, 9 months
	84470043	worker/singular: mongo sanity-check tests	rog	dimitern, mp+214189	26		11 years, 9 months
	83300047	worker/singular: new package	rog	wwitzel3, mp+213874	2		11 years, 9 months
	83590043	worker/apiaddressupdater: fix test	rog	mp+213827, axw			11 years, 9 months
	83530043	environs/cloudinit: use StateServingInfo	rog	mp+213791, fwereade	2		11 years, 9 months
	83090044	state/api: listen on localhost explicitly	rog	wwitzel3, mp+213675, mfoord			11 years, 9 months
	81570043	agent: safer and more flexible	rog	wwitzel3, dimitern, mp+213134, fwereade	22		11 years, 9 months
	81290045	agent/mongo: do not run real command	rog	wwitzel3, mp+213138, natefinch			11 years, 10 months
	79830043	bootstrap: lose BootstrapState.Characteristics	rog	mp+212665, jameinel, fwereade			11 years, 10 months
	76890049	worker: factor out NewEnvironObserver	rog	mp+212603, gz			11 years, 10 months
	79470043	state/api: further api client consolidation	rog	dimitern, mp+212425			11 years, 10 months
	78890043	state/api: implement APIHostPorts methods	rog	dimitern, mp+212219	17		11 years, 10 months
	77600048	worker/peergrouper: publish API addresses	rog	dimitern, mp+211785, mfoord	20		11 years, 10 months
	77820043	state: modify SetAPIAddresses to SetAPIHostPorts	rog	mp+211736, gz	2		11 years, 10 months
	77470043	instance: add hostport selection methods	rog	mp+211570, natefinch			11 years, 10 months
	77410043	instance: add HostPort type	rog	gz, mp+211525	4		11 years, 10 months
	76870044	state: implement WatchAPIAddresses	rog	mp+211366, natefinch			11 years, 10 months
	76950043	state: implement SetAPIAddresses	rog	mp+211356, natefinch			11 years, 10 months
	76890043	state: rename State.APIAddresses	rog	wwitzel3, dimitern, mp+211320			11 years, 10 months
	76120043	testing: mongo server helper improvements	rog	mp+211075, natefinch			11 years, 10 months
	75970043	all: use gopkg.in/v1/yaml	rog	mp+211010, axw			11 years, 10 months
	7390043	state/api: implement machine watching	rog	mp+149646, dimitern, fwereade	36		11 years, 10 months
	72230045	provider/maas: apt-get install bridge-utils	rog	mp+209885, gz, axw, fwereade	1		11 years, 10 months
	70770043	all: use errgo instead of fmt.Errorf	rog	mp+209074, natefinch			11 years, 10 months
	68650044	worker/peergrouper: implement worker	rog	mp+208204, dimitern, natefinch, fwereade	95		11 years, 11 months
	5874049	use readable time stamps on log messages.	rog	niemeyer, mp+98841			11 years, 11 months
	66000043	utils/voyeur: zero Value is ok to use	rog	mp+207184, natefinch			11 years, 11 months
	65160043	testing: use a valid fake authorized key	rog	mp+206779, jameinel, gz	3		11 years, 11 months
	65050043	all: sort imports consistently	rog	mp+206704, axw, fwereade			11 years, 11 months
	63530048	upgrades: remove unnecessary indirection layer	rog	mp+206361, fwereade			11 years, 11 months
	61010043	state: fix i/o timeout errors	rog	mp+205416, dimitern, gz	4		11 years, 11 months
	60580043	juju-restore: fix	rog	dimitern, mp+205127, gz	4		11 years, 11 months
	50590045	state: add Machine.HasVote	rog	dimitern, mp+205010	2		11 years, 11 months
	54690051	state: add MongoSession method	rog	dimitern, natefinch, mp+205013	4		11 years, 11 months
	59740049	state: add WatchStateServerInfo	rog	dimitern, mp+205019			11 years, 11 months
	10455043	code review 10455043: cmd/go: don't overwrite when pulling	rog	gustavo, rsc, dave, niemeyer			11 years, 11 months
	56070044	environs/cloudinit: enable bridging	rog	mp+203801, natefinch			11 years, 11 months
	55150043	state: implement EnsureAvailability	rog	dimitern, mp+202518, natefinch, fwereade	31		11 years, 12 months
	56680043	testing: use valid authorized keys	rog	mp+203137, dimitern, natefinch	6		11 years, 12 months
	54230044	state: deprecate JobManageState	rog	mue, dimitern, mp+202916, fwereade	11		11 years, 12 months
	56100043	state/apiserver: different logging interface	rog	mp+202909, thumper	1		11 years, 12 months
	55950043	utils/ssh, provider/local: more reliable tests	rog	dimitern, mp+202802			12 years
	53810045	state/apiserver: no need for Client ping	rog	mp+202162, natefinch			12 years
	53750043	rpc: include req duration in error responses	rog	mp+202149, natefinch			12 years
	52850043	state/apiserver: log API conn setup/teardown	rog	mp+201855, axw	2		12 years
	52460046	state/apiserver/client: longer test timeouts	rog	mp+201735, fwereade			12 years
	37650048	juju: use parallel.Try	rog	mp+199169, dimitern			12 years
	49920045	worker/peergrouper: new package	rog	mp+201245, jameinel, natefinch	10		12 years
	51480043	testing/checkers: more informative DeepEquals	rog	dimitern, mp+201432	2		12 years
	44620044	state/apiserver/client: fix redundant imports	rog	curtis, mp+199843			12 years, 1 month
	44350043	cmd/plugins: juju restore plugin	rog	mp+199711, thumper	7		12 years, 1 month
	37850043	state: AddMachine revamp continues	rog	mp+197934, dimitern	31		12 years, 1 month
	42760043	utils/parallel: concurrent attempts	rog	mp+199099, natefinch, dimitern	14		12 years, 1 month
	34710044	plugins/juju-backup: tweaks	rog	mp+197224, fwereade, dimitern	6		12 years, 1 month
	30390043	state: refactor addmachine.go	rog	wallyworld, axw, mp+196177, fwereade	16		12 years, 1 month
	30900043	state: lose machineDoc.TxnRevno	rog	mp+196275, fwereade	2		12 years, 1 month
	34050043	worker/provisioner: safe mode	rog	mp+196925, fwereade	4		12 years, 1 month
	30770043	testing/checkers: implement DeepEquals	rog	dimitern, mp+196247	16		12 years, 2 months
	29130043	juju: fix minor bug; add bug comment	rog	mp+195830, natefinch	1		12 years, 2 months
	28980043	state: factor out addmachine logic	rog	gz, mp+195768, william.reade, dimitern			12 years, 2 months
	26880043	state: create stateServers document	rog	mp+195382, gz, william.reade, natefinch	15		12 years, 2 months
	14619045	state: make Addresses use Machine.Addresses	rog	mp+191686, natefinch	8		12 years, 2 months
	14746044	provider/maas: instance and storage uniqueness	rog	mue, rvb, mp+191413	2		12 years, 3 months
	14741045	provider/maas: do not use environ-uuid	rog	natefinch, gz, mp+191367, rvb			12 years, 3 months
	14455058	provider/local: addresses on bootstrap machine	rog	mp+191001, thumper	2		12 years, 3 months
	14665043	environs/cloudinit: simplify testing	rog	mue, mp+190939			12 years, 3 months
	14426046	provider/*: standardise boilerplate	rog	dimitern, mp+189850, natefinch	18		12 years, 3 months
	14609043	state/apiserver: don't log Pings	rog	mue, natefinch, mp+190596	2		12 years, 3 months
	14531048	rpc: add notifications	rog	axw, mp+190483	6		12 years, 3 months
	14529050	rpc: new Request type	rog	gz, mp+190369			12 years, 3 months
	14395043	agent: implement InitializeState	rog	mue, mp+189384, fwereade	19		12 years, 3 months
	14540044	worker/addressupdater: back off failed lookups	rog	mp+189857, fwereade			12 years, 3 months
Unsent issues (3)
Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
	65740046	all: use errgo.Cause	rog	mp+207128			11 years, 11 months
	62230043	state/..., worker/..., utils/...: use errgo	rog	mp+206024			11 years, 11 months
	22100045	state/apiserver: charm stream demo	rog	mp+194183			12 years, 2 months
Issues CCd to (10)
Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
	5630052	code review 5630052: database/sql: treat pointers as nullable types like enc...	awpritchard	ikedam, bradfitz			4 years
	9454043	code review 9454043: spdy: add net/http hook	kr		29		11 years, 1 month
	179540043	code review 179540043: encoding/xml: respect name spaces when encoding	roger.peppe1	martin.hilton, matthew.scott	11		11 years, 1 month
	6396046	code review 6396046: gotour: new design	tux21b	adg	9		13 years, 4 months
	5449077	code review 5449077: crypto/aes: Made faster by eliminating some indirection	taruti	rsc	2		14 years, 1 month
	4528133	code review 4528133: bufio: Reader only returns cached error once	gmiller	rsc	7		14 years, 7 months
	4388048	code review 4388048: net: sort records returned by LookupMX	cthom	adg	4		14 years, 9 months
	4356046	ld: Include bss section of GCC-built Mach-O objects in ...	mkrautz	rsc			14 years, 9 months
	4132044	code review 4132044: netchan: graceful handling of closed connection	gmiller	r			14 years, 11 months
	2049043	code review 2049043: Add Linux inotify support	leczb	rsc1	54		15 years, 1 month
Closed Recently (0)
(None)

Incoming reviews (100)

Outgoing reviews (97)

Unsent issues (3)

Issues CCd to (10)

Closed Recently (0)