Issues for khr - Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issues for khr

Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
Incoming reviews (14)
	107780045	cmd/gc: add new comment directive //go:nosplit.	minux	khr			11 years, 7 months
	69650043	code review 69650043: undo CL 46810043 / 13f8dc6e750f	dave	minux1, khr, rsc			11 years, 10 months
	10321043	code review 10321043: runtime: move stack segment cache from M to P	dvyukov	gobot, khr, golang-codereviews, bradfitz			11 years, 11 months
	4575053	code review 4575053: sync: add Semaphore	kevlar	khr, dave			12 years
	5585043	code review 5585043: exp/fsnotify: Cross-platform filesystem notifications	howeyc	minux1, taralx, khr, robfig, dave, undriedsea, brainman, mattn, golang-dev			12 years, 6 months
	6846119	code review 6846119: godoc: remove main package if main and once more packag...	mattn	minux1, golang-dev, khr, rsc			12 years, 6 months
	6902069	code review 6902069: regexp/syntax: export ErrUnexpectedParen	bketelsen	khr, rsc			12 years, 6 months
	8136043	code review 8136043: testing: report test as failed if the test panics.	Ewan Chou	minux1, khr			12 years, 6 months
	8174045	code review 8174045: misc/cgo: fix typo.	aam	minux1, khr			12 years, 6 months
	8171044	code review 8171044: cmd/go: document usage of external test packages	kisielk	adg, khr	6		12 years, 6 months
	6976049	code review 6976049: godoc: really restore toy selection to playground widget	amir	minux1, adg, khr, golang-dev			12 years, 7 months
	6712047	code review 6712047: exp/html: update an example in the documentation to mat...	phaikawl	nigeltao, khr, golang-dev			12 years, 7 months
	6682046	code review 6682046: container/list: fix typo	taj	minux1, nigeltao, khr, dave, albert.strasheim, golang-dev	2		12 years, 7 months
	9948043	bytes: improved bytes.Equal for arm	dave				12 years, 7 months
Outgoing reviews (5)
Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
	178380043	[dev.cc] code review 178380043: runtime: fix finalizer iterator	khr	rsc			11 years, 1 month
	177820043	code review 177820043: 5l: add veneers to handle arm->thumb transitions.	khr				11 years, 1 month
	165950043	code review 165950043: runtime: allocate a list of small integers that interfa...	khr	gri, rsc	4		11 years, 1 month
	84590043	code review 84590043: reflect: do makeFuncStub shortcut after dotdotdot args ...	khr	bradfitz, rsc, khr1, iant			11 years, 9 months
	8637048	code review 8637048: runtime: make sure we have sse2 instructions	khr	minux1, khr1, r, lucio, golang-dev, bradfitz	10		12 years, 7 months
Unsent issues (41)
Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
	181650044	runtime: make stack frames fixed size by modifying gopr...	khr				11 years, 1 month
	158230043	runtime: use doubly-linked lists for channel send/recv ...	khr				11 years, 1 month
	167240043	runtime: make stack frames fixed size by modifying gopr...	khr				11 years, 1 month
	182810045	runtime: redo heap metadata to use only 2 bits per pointer	khr				11 years, 1 month
	171240043	runtime: make findfunc faster	khr				11 years, 1 month
	145380043	runtime: faster aeshash implementation	khr				11 years, 1 month
	146810044	runtime: use xxhash as fallback when aeshash is not available	khr				11 years, 1 month
	154400043	runtime: get rid of BitsMultiword. Encode interfaces a...	khr				11 years, 3 months
	156010044	runtime: clear m.morebuf pointers.	khr				11 years, 3 months
	139160043	cmd/5g: code motion doesn't recognize floating-point loads	khr				11 years, 4 months
	119050043	reflect: shrink reflect.Value back to 3 words	khr				11 years, 6 months
	108310043	undo CL 101570044 / 2c57aaea79c4	khr				11 years, 6 months
	108300044	runtime: silence race detector on reused stack memory.	khr				11 years, 6 months
	101370054	runtime: use only 2 bits in gc bitmap.	khr				11 years, 7 months
	99650044	runtime: Use explicit moves instead of REP prefix for l...	khr				11 years, 7 months
	99430048	runtime: explicit pcdata ops for faulting instructions.	khr				11 years, 8 months
	94710043	runtime: disable map iteration order randomness.	khr				11 years, 8 months
	100000043	runtime: experiment with inlined strings	khr				11 years, 8 months
	94770043	runtime: use find-first-bit to do branch inside memclr.	khr				11 years, 9 months
	58170047	runtime: Implement go->c calls as idempotent.	khr				11 years, 9 months
	82990043	godoc: add heap dump handler	khr				11 years, 9 months
	76920043	runtime: test that empty slices/strings	khr				11 years, 10 months
	70520044	runtime: fix stats used by GC to decide when next GC sh...	khr				11 years, 10 months
	64300043	runtime: some map optimizations	khr				11 years, 11 months
	55700045	runtime: Type comparison & hashing in constant stack space.	khr				11 years, 12 months
	55380043	cmd/cc: Arg ptr maps: special cases for Iface and Eface	khr				12 years
	52670045	reflect: use interface{} in Value to get back to 3 word...	khr				12 years
	50760043	net/http: Test of bufio.Reader reuse.	khr				12 years
	35920044	runtime: pass arguments to chan functions by pointer	khr				12 years
	36210043	runtime: pass args & return values to type check assert...	khr				12 years, 1 month
	28870043	runtime: do a full traceback at every function entry point.	khr				12 years, 2 months
	23250043	runtime: experiment for running hash map operations on ...	khr				12 years, 2 months
	22290044	runtime, cmd/gc: copying stacks vs. unsafe.Pointer	khr				12 years, 2 months
	13603044	runtime: Make hashing big objects faster by parallelizi...	khr				12 years, 4 months
	12119043	runtime: Trying a different map implementation.	khr				12 years, 5 months
	9029047	runtime: contiguous stacks	khr				12 years, 6 months
	10195043	cmd/[568]c: add LOCALS opcode.	khr				12 years, 7 months
	9340045	cmd/gc: remove hash rotate, no longer needed with aeshash.	khr				12 years, 8 months
	8984043	gc/ld/runtime: nil pointer checks using only hardware	khr				12 years, 9 months
	7381059	pkg/runtime: bit-sliced hashmap implementation	khr				12 years, 11 months
	7304099	runtime: Improve the map implementation.	khr				12 years, 11 months
Issues CCd to (19)
Id		Subject	Owner	Reviewers	Comments	Drafts	Last updated
	176430043	[dev.cc] code review 176430043: runtime: add execution tracing functionality	dvyukov		84		11 years, 1 month
	172510043	[dev.cc] code review 172510043: runtime: fix GODEBUG processing	aram				11 years, 1 month
	139620043	code review 139620043: runtime: convert windows netpoll to Go	dvyukov		1		11 years, 1 month
	138390043	code review 138390043: runtime: convert solaris netpoll to Go	dvyukov	aram	17		11 years, 1 month
	112990043	code review 112990043: runtime: fine-grained locking in select	dvyukov				11 years, 1 month
	107540044	code review 107540044: runtime: redirect stdout and stderr to logcat for android	crawshaw	adonovan	32		11 years, 1 month
	101330056	code review 101330056: doc: ban data races	dvyukov	dave	1		11 years, 1 month
	171680043	[dev.cc] code review 171680043: runtime: make lock-free stack work with high canonical amd64	aram	rsc			11 years, 2 months
	138040044	runtime: fix mgc0	dvyukov				11 years, 3 months
	139630043	runtime: convert windows netpoll to Go	dvyukov				11 years, 4 months
	131670043	code review 131670043: runtime: convert cgocall to Go	dvyukov	gobot, khr, rsc	16		11 years, 4 months
	133260043	syscall: convert Syscall to Go	dvyukov	aram, brainman	3		11 years, 4 months
	131010044	code review 131010044: runtime,runtime/debug: Converted some functions from go...	sanjay.m	gobot, khr, khr1	2		11 years, 5 months
	108120046	runtime: verify size of Hmap struct	dvyukov				11 years, 7 months
	102820043	code review 102820043: cmd/gc: fix x=x crash	rsc	r, gobot, khr			11 years, 7 months
	75370043	code review 75370043: reflect: Fix variadic arg arrangement for funcs created...	crc	khr, rsc	1		11 years, 9 months
	70200056	code review 70200056: runtime: Generic hash and equal for types with nil alg-...	crc	rsc, golang-codereviews			11 years, 10 months
	10321043	code review 10321043: runtime: move stack segment cache from M to P	dvyukov	gobot, khr, golang-codereviews, bradfitz			11 years, 11 months
	57070043	runtime: fix windows build	dvyukov				11 years, 12 months
Closed Recently (0)
(None)

Incoming reviews (14)

Outgoing reviews (5)

Unsent issues (41)

Issues CCd to (19)

Closed Recently (0)