rvalyi/mergiraf
1
0
Fork 0
forked from mergiraf/mergiraf
Code Pull requests Activity

Improvements to Python support #1

Merged
rvalyi merged 1 commit from wetneb/mergiraf:python_improvements into add-python 2024-11-28 21:38:36 +01:00
Conversation 1 Commits 1 Files changed 22 +94 -8
wetneb commented 2024-11-26 17:12:07 +01:00
Contributor
Copy link

Hi @rvalyi,

Thanks a lot for your work on Python support for Mergiraf!
I had a go at improving your initial implementation by:

  • restricting commutativity to certain contexts, to be on the safe side
  • adding a few more commutative parents, such as to handle keyword arguments in functions or sets
  • and a few test cases to demonstrate it all

Merging this PR will update your original PR in the upstream repo.

Hi @rvalyi, Thanks a lot for your work on Python support for Mergiraf! I had a go at improving your initial implementation by: * restricting commutativity to certain contexts, to be on the safe side * adding a few more commutative parents, such as to handle keyword arguments in functions or sets * and a few test cases to demonstrate it all Merging this PR will update your original PR in the upstream repo.
rvalyi approved these changes 2024-11-28 21:37:37 +01:00
rvalyi left a comment
Owner
Copy link

seems ok thank you for the extensive work. I experimented earlier with some of your changes I did on my side. As for you other changes they seem ok, I'm testing more extensively with my Odoo/OCA projects and I will report if I see something wrong...

seems ok thank you for the extensive work. I experimented earlier with some of your changes I did on my side. As for you other changes they seem ok, I'm testing more extensively with my Odoo/OCA projects and I will report if I see something wrong...
rvalyi merged commit d022d8b210 into add-python 2024-11-28 21:38:36 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
rvalyi
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rvalyi/mergiraf#1
No description provided.
Delete branch "wetneb/mergiraf:python_improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?