fix(AstNode::bundle_comments): don't bundle at A, // comment \n B #588

ada4a · 2025-09-12T01:19:15+02:00

ada4a commented

2025-09-12 01:19:15 +02:00

Fixes #586

ada4a added 5 commits

2025-09-12 01:19:16 +02:00

make ctx.parse track the caller 47e3624cfd

so that we see which test that invoked it was the one that failed

AstNode::ascii_tree: add colorize: bool parameter 837ec150f6

add an obscene amount of tests c04bc9c1a9

switch from `fn`s to `mod`s, since they have one fewer children

replace with match c465180f29

This commit doesn't change any logic -- it's only separated from the
next one to hopefully make the latter's diff easier to understand.

fix

/ test (pull_request) Successful in 35s

Details

75b715d451

ada4a force-pushed bundle-comments-fix1 from 75b715d451 to 9d9b17afdd

2025-09-12 01:19:20 +02:00

Compare

wetneb approved these changes

2025-09-14 10:41:51 +02:00

Dismissed

src/ast/bundle_comments.rs Outdated

					
				@ -870,0 +1090,4 @@

				                let rs = ctx.parse("a.rs", source);

				                assert_eq!(rs.ascii_tree(Some(5), false), BUNDLED_INTO_ABOVE);

				            }

wetneb commented

2025-09-14 10:31:35 +02:00

The comment says don't bundle but the test asserts that it does - or do I misunderstand the comment? There are a couple of similar cases below.

ada4a commented

2025-09-14 13:47:52 +02:00

No, you're right -- the comments got out of sync when copy-pasting.. To help that a little, I removed all the comments from the tests where expected is a constant, because the name of the constant already describes what the expectation is.

No, you're right -- the comments got out of sync when copy-pasting.. To help that a little, I removed all the comments from the tests where `expected` is a constant, because the name of the constant already describes what the expectation is.

ada4a marked this conversation as resolved

wetneb reviewed

2025-09-14 10:42:58 +02:00

src/ast/bundle_comments.rs Outdated

					
				@ -870,0 +1158,4 @@

				                let rs = ctx.parse("a.rs", source);

				                assert_eq!(rs.ascii_tree(Some(4), false), BUNDLED_INTO_ABOVE_SAME_LINE);

				            }