refactor(tests): Inline all language-specific parse methods #530

Merged

wetneb merged 3 commits from wetneb/remove_lang_specific_parse_methods into main

2025-07-24 15:17:19 +02:00

AGit

wetneb commented

2025-07-24 15:00:58 +02:00

Owner

I get annoyed of the need to define a new TestContext::parse_blah method every time I write a test using a language that's not used in unit tests already. It feels easy enough to provide a filename from which the language can be generated.

So this PR removes them… but it's really a matter of taste, I can also live with adding those methods.

I get annoyed of the need to define a new `TestContext::parse_blah` method every time I write a test using a language that's not used in unit tests already. It feels easy enough to provide a filename from which the language can be generated. So this PR removes them… but it's really a matter of taste, I can also live with adding those methods.

wetneb added 3 commits

2025-07-24 15:00:58 +02:00

refactor(tests): Rename TestContext::parse_internal to just parse 31b0856097

refactor(tests): Make TestContext::parse public 9c4c9602ec

refactor(tests): Inline all language-specific parse methods

/ test (pull_request) Successful in 42s

Details

f1470078b3

ada4a approved these changes

2025-07-24 15:09:58 +02:00

ada4a left a comment

Owner

Fair enough.. though it's still a bit annoying that we need to look-up LangProfiles for languages that we know we support. But I don't know of any solution other than maybe definining a const (or, well, a LazyLock) for each language and referring to that when calling ctx.parse – which arguably wouldn't even save us that many characters

Fair enough.. though it's still a bit annoying that we need to look-up `LangProfile`s for languages that we know we support. But I don't know of any solution other than maybe definining a const (or, well, a `LazyLock`) for each language and referring to _that_ when calling `ctx.parse` – which arguably wouldn't even save us that many characters