fix: Avoid displaying spurious conflicts #371

Merged
wetneb merged 8 commits from wetneb/mergiraf:356-spurious-conflicts into main 2025-05-10 21:11:47 +02:00

8 commits

Author SHA1 Message Date
76fb75154f
restore iter::once to make the overall Either an Iterator
All checks were successful
/ test (pull_request) Successful in 58s
could replace the `iter::Once` in the return type signature, but I think
it's actually nice, since it signifies that in that case, we return the
`MergedTree:Conflict`, _once_
2025-05-10 15:06:43 +02:00
92faed6fdf
use Either to avoid the "different types" error 2025-05-10 15:02:11 +02:00
82ddd32cfe
move to fix the ownership problem
all we needed was to have `{first,second}_rev` inside the closure
2025-05-10 15:01:36 +02:00
30520f9da5
return impl Iterator
doesn't compile, since the types of the last branch is technically
different from the rest
2025-05-10 15:01:35 +02:00
6d97d27ffc
turn into fn 2025-05-10 14:48:05 +02:00
2aab49821d
use into_iter 2025-05-10 14:47:20 +02:00
165400d47f Also check for isomorphism when building the merged tree
All checks were successful
/ test (pull_request) Successful in 58s
2025-05-10 09:40:21 +02:00
da18c04dd2 fix: Avoid displaying spurious conflicts
Fixes #356.
Not including the original case as integration test case because I
didn't manage to minimize it sufficiently. I think the unit test is
enough.
2025-05-10 08:50:30 +02:00