mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 50 Pull requests 7 Releases 19 Activity Actions

Support for restricting commutativity #33

Merged
wetneb merged 3 commits from wetneb/mergiraf:5-restrict-commutativity into main 2024-11-19 15:24:36 +01:00
Conversation 3 Commits 3 Files changed 12 +159 -11
wetneb commented 2024-11-14 22:11:36 +01:00
Owner
Copy link

This is one attempt to add support for restricting which types of children are able to commute inside a commutative parent (#5).
For each commutative parent, one can define any number of "children groups", which are lists of children types allowed to commute together.
If no children groups are provided, the current behaviour of letting all children commute remains.

I don't know if this is the right way to specify this. As the failing example demonstrates, this also forbids reordering as soon as there is a comment involved (unless comments are explicitly added in the children groups), which is perhaps a good thing given that we're not able to handle them reliably yet (#26).

@zanbaldwin @keirlawson does this go in the right direction?

This is one attempt to add support for restricting which types of children are able to commute inside a commutative parent (#5). For each commutative parent, one can define any number of "children groups", which are lists of children types allowed to commute together. If no children groups are provided, the current behaviour of letting all children commute remains. I don't know if this is the right way to specify this. As the failing example demonstrates, this also forbids reordering as soon as there is a comment involved (unless comments are explicitly added in the children groups), which is perhaps a good thing given that we're not able to handle them reliably yet (#26). @zanbaldwin @keirlawson does this go in the right direction?
wetneb force-pushed 5-restrict-commutativity from 4c438aae9a to f7cd837693 2024-11-14 22:12:11 +01:00 Compare
wetneb reviewed 2024-11-14 22:12:43 +01:00
src/supported_langs.rs Outdated
@ -213,0 +220,4 @@
ChildrenGroup::new(&["field_declaration"]),
ChildrenGroup::new(&["function_definition"])
],
}
wetneb commented 2024-11-14 22:12:43 +01:00
Author
Owner
Copy link

Here is an example of how it can be used in a language profile.

Here is an example of how it can be used in a language profile.
keirlawson commented 2024-11-14 22:23:42 +01:00
Contributor
Copy link

If I'm understanding the examples correctly these groups members have to all be adjacent to each other, this fits the Scala use case well as we might have imports defined lower down in our program that change behavior that we wouldn't want to commute with the traditional imports at the top of the file.

If I'm understanding the examples correctly these groups members have to all be adjacent to each other, this fits the Scala use case well as we might have imports defined lower down in our program that change behavior that we wouldn't want to commute with the traditional imports at the top of the file.
👍 1
wetneb force-pushed 5-restrict-commutativity from 7c7a9536f7 to 3b85eac4cb 2024-11-19 15:11:28 +01:00 Compare
wetneb changed title from WIP: Support for restricting commutativity to Support for restricting commutativity 2024-11-19 15:22:47 +01:00
wetneb commented 2024-11-19 15:23:55 +01:00
Author
Owner
Copy link

Let's merge this already, for the sake of enabling the feature for other languages. I intend to go through existing languages and review if they would benefit from the feature.

Let's merge this already, for the sake of enabling the feature for other languages. I intend to go through existing languages and review if they would benefit from the feature.
wetneb merged commit 13ad29591b into main 2024-11-19 15:24:36 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#33
No description provided.
Delete branch "wetneb/mergiraf:5-restrict-commutativity"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?