mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 51 Pull requests 7 Releases 19 Activity Actions

refactor(lib): extract logic for mergiraf {merge,solve} out into separate modules #297

Merged
ada4a merged 4 commits from ada4a/mergiraf:split_merge_and_solve into main 2025-04-16 11:42:30 +02:00
Conversation 6 Commits 4 Files changed 3 +391 -367
ada4a commented 2025-03-29 16:18:44 +01:00
Owner
Copy link

I remember first delving into lib.rs, and feeling very lost jumping
between similarly-named functions placed in a seemingly random order. I
believe that after numerous restructurings (#123, #127, #132, #157), a
clearer structure has started to emerge, and this PR will hopefully be
the final step required.

Very pompous, I know, but that's not totally unwarranted I think

I remember first delving into `lib.rs`, and feeling very lost jumping between similarly-named functions placed in a seemingly random order. I believe that after numerous restructurings (#123, #127, #132, #157), a clearer structure has started to emerge, and this PR will hopefully be the final step required. Very pompous, I know, but that's not totally unwarranted I think
ada4a commented 2025-03-29 16:20:33 +01:00
Author
Owner
Copy link

I'm pretty sure this will break every single WIP PR, but oh well 😅

I'm pretty sure this will break every single WIP PR, but oh well 😅
wetneb approved these changes 2025-03-29 17:31:22 +01:00
wetneb left a comment
Owner
Copy link

Yay! Makes a lot of sense.

Yay! Makes a lot of sense.
ada4a commented 2025-03-30 22:30:38 +02:00
Author
Owner
Copy link

Glad you like it! I don't want to stall #296 for no reason, so I'll wait with this one until that one's merged:)

Glad you like it! I don't want to stall #296 for no reason, so I'll wait with this one until that one's merged:)
ada4a force-pushed split_merge_and_solve from b13aaef0f0 to 31115451b2 2025-04-05 12:50:29 +02:00 Compare
ada4a commented 2025-04-05 12:50:47 +02:00
Author
Owner
Copy link

rebased onto main

rebased onto main
ada4a commented 2025-04-12 17:56:13 +02:00
Author
Owner
Copy link

Given that there was no response from #296, would you be okay with me merging this and asking you to resolve the resulting conflicts there @wetneb?

Given that there was no response from #296, would you be okay with me merging this and asking you to resolve the resulting conflicts there @wetneb?
wetneb commented 2025-04-16 09:45:06 +02:00
Owner
Copy link

Fine by me, there are already conflicts to resolve there anyway.

Fine by me, there are already conflicts to resolve there anyway.
ada4a merged commit 98035a8768 into main 2025-04-16 11:42:30 +02:00
ada4a deleted branch split_merge_and_solve 2025-04-16 11:42:31 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
wetneb
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#297
No description provided.
Delete branch "ada4a/mergiraf:split_merge_and_solve"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?