mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 50 Pull requests 7 Releases 19 Activity Actions

more-cpp-extensions #295

Merged
ada4a merged 2 commits from mathstuf/mergiraf:more-cpp-extensions into main 2025-03-30 16:18:21 +02:00
Conversation 4 Commits 2 Files changed 3 +6 -2
mathstuf commented 2025-03-28 20:43:28 +01:00
Member
Copy link
No description provided.
ada4a commented 2025-03-28 23:01:20 +01:00
Owner
Copy link

Hi, thanks again for the PR!

After some quick googling, it looks like there are even more extensions for C++... I'm pretty sure you're more knowledgeable about this than I am, so -- should we add them to the list as well? Or are they rather uncommon in practice?

Hi, thanks again for the PR! After some quick googling, it looks like there are [even more](https://stackoverflow.com/a/76422027) extensions for C++... I'm pretty sure you're more knowledgeable about this than I am, so -- should we add them to the list as well? Or are they rather uncommon in practice?
mathstuf commented 2025-03-29 13:30:21 +01:00
Author
Member
Copy link

I'm aware of others (we support them in CMake after all). There are also a raft of header extensions not listed here as well. I've yet to see those I've not added in the wild though.

I'm aware of others (we support them [in CMake](https://gitlab.kitware.com/cmake/cmake/-/blob/7885d5edd93ff7876a8d3cca456530f30297498e/Modules/CMakeCXXCompiler.cmake.in#L48) after all). There are also a raft of header extensions not listed here as well. I've yet to see those I've not added in the wild though.
mathstuf force-pushed more-cpp-extensions from d0fab23e51 to 567711becc 2025-03-29 13:34:20 +01:00 Compare
ada4a commented 2025-03-29 15:28:48 +01:00
Owner
Copy link

Thanks for fixing the test! Could you please update 4f8f4273bb/doc/src/languages.md as well?

Note to self (CC @wetneb): the languages_gitattributes test asserts only doc/src/supported_langs.txt, and only suggests changing doc/src/languages.md. I wonder if one could a define CI workflow that ensures that if a PR touches src/supported_langs.rs (99% of time that would be SUPPORTED_LANGUAGES modification), then it must also touch doc/src/languages.md and doc/src/supported_langs.txt.

I'm aware of others (we support them in CMake after all). There are also a raft of header extensions not listed here as well. I've yet to see those I've not added in the wild though.

Okay, so I'd say we don't add those -- #296 should cover these rare extensions. This should be good to go after the docs are updated

Thanks for fixing the test! Could you please update https://codeberg.org/mergiraf/mergiraf/src/commit/4f8f4273bba73403aeaef188957c0f615a290c11/doc/src/languages.md as well? Note to self (CC @wetneb): the `languages_gitattributes` test _asserts_ only `doc/src/supported_langs.txt`, and only _suggests_ changing `doc/src/languages.md`. I wonder if one could a define CI workflow that ensures that if a PR touches `src/supported_langs.rs` (99% of time that would be `SUPPORTED_LANGUAGES` modification), then it must also touch `doc/src/languages.md` and `doc/src/supported_langs.txt`. > I'm aware of others (we support them in CMake after all). There are also a raft of header extensions not listed here as well. I've yet to see those I've not added in the wild though. Okay, so I'd say we don't add those -- #296 should cover these rare extensions. This should be good to go after the docs are updated
mathstuf force-pushed more-cpp-extensions from 567711becc to cb9d20bd13 2025-03-30 16:13:58 +02:00 Compare
ada4a approved these changes 2025-03-30 16:18:07 +02:00
ada4a left a comment
Owner
Copy link

Thanks again!

Thanks again!
ada4a merged commit ec70384b52 into main 2025-03-30 16:18:21 +02:00
ada4a referenced this pull request from a commit 2025-03-30 16:18:23 +02:00
more-cpp-extensions (#295)
Sign in to join this conversation.
Reviewers
No reviewers
ada4a
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#295
No description provided.
Delete branch "mathstuf/mergiraf:more-cpp-extensions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?