mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 50 Pull requests 6 Releases 19 Activity Actions

fix(AstNode::parse): respect char boundaries of source when informing about a parse error #558

Merged
wetneb merged 3 commits from ada4a/mergiraf:ast-parse-fail-char-boundary into main 2025-08-02 09:35:02 +02:00
Conversation 2 Commits 3 Files changed 3 +44 -5
ada4a commented 2025-08-02 01:02:24 +02:00
Owner
Copy link

fixes the panic mentioned in #557 (comment)

fixes the panic mentioned in https://codeberg.org/mergiraf/mergiraf/pulls/557#issuecomment-6095173
❤️ 1
move ceil_char_boundary beside PathBufExt
All checks were successful
/ test (pull_request) Successful in 34s
Details
efdf8c8788
ada4a changed title from fix(AstNode::parse): respect char boundaries of source when informing about an parse error to fix(AstNode::parse): respect char boundaries of source when informing about a parse error 2025-08-02 01:03:20 +02:00
wetneb approved these changes 2025-08-02 07:58:09 +02:00
wetneb left a comment
Owner
Copy link

Amazing that you were able to debug this even without a reproducing test case! I felt bad of just dropping the log of the panic without more info… Thank you!

Amazing that you were able to debug this even without a reproducing test case! I felt bad of just dropping the log of the panic without more info… Thank you!
wetneb merged commit 68b86fb426 into main 2025-08-02 09:35:02 +02:00
ada4a deleted branch ast-parse-fail-char-boundary 2025-08-02 14:04:40 +02:00
ada4a commented 2025-08-02 14:07:50 +02:00
Author
Owner
Copy link

I largely owe that to the descriptive panic message that we got from std, but thank you ☺️

I largely owe that to the descriptive panic message that we got from std, but thank you :relaxed:
Sign in to join this conversation.
Reviewers
No reviewers
wetneb
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#558
No description provided.
Delete branch "ada4a/mergiraf:ast-parse-fail-char-boundary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?