Switch to tree-sitter-dart-orchard
#557
No reviewers
Labels
No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: mergiraf/mergiraf#557
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "wetneb/dart_update"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
New version of #405, updating the grammar to a new version.
I fixed an issue in the grammar which meant that semicolons were treated as direct children of class bodies, hence the test failure that we noticed in #405.
Switch to tree-sitter-dart-orchardto Switch totree-sitter-dart-orchard
LGTM, but I'd wait for @HannesGitH's input as well
I was a bit worried that the semicolon issue was the tip of the iceberg, so I ran a benchmark before and after this PR:
*.dart
Yay, another panic!
Also the new conflicts seem like they're worth inspecting as they are likely a symptom for a new problem in the grammar.
ah, the panic is because we take the first 32 bytes of a
&str
, but that happens not to lie on a character boundary in this caseLgtm as well
All forks of the original tree-sitter-dart (including the one I proposed) seem rather dead so I think it's reasonable to host and use a new fork
AstNode::parse
): respect char boundaries ofsource
when informing about a parse error #5580924bf4d04
to8dd701eeb7