Use sorttable to make tables dynamic sort

Brought to you by: fmarchal, orso

#28 Use sorttable to make tables dynamic sort

Status: open-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2011-02-19

Created: 2010-11-02

Creator: Anonymous

Private: No

Hello world,
i've tried to include http://www.kryogenix.org/code/browser/sorttable/ into SARG reports, it's great.

With this js file you can sort any HTML table ... here is a topsite.c with sorttable include. You have to download sorttable.js and put it in SARG wwwroot ... please send me an email if you're interrested in a full patch for SARG + SORTTABLE.

Éric

Discussion

Nobody/Anonymous - 2010-11-02

tomsite with

topsites.c

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Frederic Marchal - 2010-11-04

The sample file you provide is from a version of sarg I could not identify. I could not extract a proper diff with just the changes you made.

Nevertheless, this is an excellent suggestion and I'm going to add it to sarg 2.4 (that is, once I start working on it :-) ).

Thanks for the link.

Frederic

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Frederic Marchal - 2010-11-20

status: open --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Murilo Moreira de Oliveira - 2011-02-16

I've not verified the content of sorttable.js, but it worked as expected. I've made some changes in and the corresponding reports are now sortable. Some improvements have to be done like not sort TOTAL and AVERAGE lines, but the result is good for now. Follow patch files for sarg 2.3.1.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Murilo Moreira de Oliveira - 2011-02-16

status: closed-accepted --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Murilo Moreira de Oliveira - 2011-02-16

The sorttable.js script was saved in my web root directory (DocumentRoot parameter in apache conf). The www_document_root parameter in sarg.conf was changed to http://MY_WEB_SERVER_ROOT_ADDRESS.
How can I attach my patch files to this issue?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Frederic Marchal - 2011-02-17

status: open-accepted --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Frederic Marchal - 2011-02-17

The support for sorttable.js is available since November 20, 2010. What issue do you want to provide a patch for ?

The current svn source can be fetched from svn with this command: [code]svn co https://sarg.svn.sourceforge.net/svnroot/sarg/branches/v2.3 .[/code] If you provide a patch, be sure to build it against that version.

I still haven't decided whether I'll distribute a patched version of sorttable.js along with sarg or not. The original project looks dead.

Frederic

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Murilo Moreira de Oliveira - 2011-02-17

I didn't know that sarg supported sorttable.js (your post in 2010-11-04 doesn't say this). The patch files I've created are for last sarg stable version (2.3.1). The changed files are util.c, siteuser.c, topuser.c and siteuser.c. A side effect, as I said, is the incorrect sort of TOTAL and AVERAGE lines. Columns with values with different suffixes ("Kilo", "Mega", ie) are incorrectly sorted too. As I don't have permission to attach files to this issue, I can send you the patch files by e-mail, if you want.
I see. Considering the "Sortable Project" status, I think that would be interesting sarg provides a patched version of sorttable.js.
At last, I would like to ask, please add to sarg the ability of dynamically sort columns. This is a very desired functionality in sarg reports. Thanks for everything.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Frederic Marchal - 2011-02-19

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Frederic Marchal - 2011-02-19

On November 4th, I said I would add support for sorttable to sarg 2.4 but the feature was so exciting and easy to implement that I programmed it almost immediately. It will be available in sarg 2.3.2.

Don't waste your time reimplementing it. The feature is fully functional now. If you can't wait for sarg 2.3.2, you can check out the source from svn. It is development code but it should be quite stable. I'm using it on a production server.

Thank you for pointing to sorttable by the way.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Murilo Moreira de Oliveira - 2011-02-19

I'll test the svn version. All the best.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Murilo Moreira de Oliveira - 2011-02-19

status: closed-fixed --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nobody/Anonymous - 2011-06-11

it's failing for Table columns with textbox.
<td><input type="text" name="some name"></td>

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Frederic Marchal - 2011-06-14

I haven't released a patched sorttable.js yet. If you are using the original one, you should try to report the bug to the official author first.

Where does sarg produce such a table in conjunction with sorttable?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.