[go: up one dir, main page]

Menu

#5874 DW2: US version uses UK graphics

Discworld II
closed-fixed
Graphics (902)
5
2011-10-15
2011-10-12
No

US "Mortality Bytes" version of the game
Current ScummVM git snapshot

This was already mentioned in bug #2772743 ("DW2: Unsupported US version?"), but rather than reopening that one (which was mainly about having to rename files in the US version to get it to run), I'm filing a new bug report.

When running the US version in DOSBox, it shows a "Mortality Bytes" title screen and shows a US flag in the settings dialog. When running it in ScummVM, it shows the same "Missing Presumed..." title screen and UK flag as the UK version. I'll attach some DOSBox screenshots to show what I mean.

Discussion

  • Torbjörn Andersson

    Title screen (DOSBox)

     
  • Torbjörn Andersson

    It looks like both of these can be fixed by making sure that _language is set to TXT_US instead of TXT_ENGLISH if the language is Common::EN_USA in Config::readFromDisk(). I'm not quite confident enough about that to make that change without at least discussing it with someone first.

     
  • Torbjörn Andersson

    A similar change may have to be made to Config::writeToDisk() as well, I guess.

     
  • Paul Gilbert

    Paul Gilbert - 2011-10-13

    I don't have the US version to test with, but it seems like only the two methods you list below would need to be changed. I'd suggest that if no one else with the US version comes forward to try making the change, you go ahead and do it, and commit it if it works.

     
  • Torbjörn Andersson

    • assigned_to: nobody --> eriktorbjorn
    • status: open --> open-fixed
     
  • Torbjörn Andersson

    Thanks. I've made the change, and added a note to the NEWS file. Hopefully I'll be able to play through the game before the 1.4.0 release, but right now there's an annoying regression from commit d5690e0. (See note on GitHub for details, though you should already have received an automated mail about it.)

     
  • digitall

    digitall - 2011-10-15

    eriktorbjorn: Regression fixed by dreammaster in 6811a3daffc2743d2d733050be9306dcbf419214. Closing this.

     
  • digitall

    digitall - 2011-10-15
    • status: open-fixed --> closed-fixed