Menu
▾
▴
1 Attachments
#2495 Segfault when destroying ScintillaDocument [Qt]
The following test program seg-faults (GCC 15.2.0 on Ubuntu 25.10) when the ScintillaDocument is destroyed:
#include <ScintillaDocument.h>
#include <ScintillaEdit.h>
#include <QApplication>
int main(int argc, char * argv[])
{
QApplication app(argc, argv);
ScintillaEdit edit;
ScintillaDocument doc;
edit.set_doc(&doc);
return 0;
}
Analysis: ScintillaDocument::ScintillaDocument calls Document::AddWatcher with a second argument of type IDocumentEditable *. However, ScintillaDocument::~ScintillaDocument calls Document::RemoveWatcher with second argument of type Document*. The two are related, of course (Document derives from IDocumentEditable), but the pointers differ due to different vtables. Thus, Document::RemoveWatcher fails to remove the watcher, subsequently resulting in the segfault when ~Document tries to notify the (not properly removed) watcher.
Attached is a patch that fixes the issue by using the Document* also in ScintillaDocument::ScintillaDocument
Committed as [04be64].
Related
Commit: [04be64]