Johan Ström
-
2015-03-11
- Status: open --> merged
Menu
▾
▴
Code (obsolete) Merge Request #6: [re-merge] owwrite: fix writing of hex '00', which failed to write (merged)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Johan Ström wants to merge 0 commits from /u/stromnet/owfs/ to master, 2015-03-11
(This is a new merge-request replacing the previous one at https://sourceforge.net/p/owfs/code/merge-requests/4/. It seems the previous one did not have a proper source branch. This merge request is against current master).
This fix an issue with owwrite handling binary data as strings, writing hex 00 would break the string prematurely. Example transaction:
owwrite --hex /uncached/12.AD00B4D0BE42/pages/page.0 1010
Byte buffer FD, length=41
--000: 2F 75 6E 63 61 63 68 65 64 2F 31 32 2E 41 44 30
--016: 30 42 34 44 30 42 45 34 32 2F 70 61 67 65 73 2F
--032: 70 61 67 65 2E 30 00 10 10
DEBUG: ow_tcp_read.c:(113) read: 41 - 0 = 41
owwrite --hex /uncached/12.AD00B4D0BE42/pages/page.0 0000
Byte buffer FD, length=39
--000: 2F 75 6E 63 61 63 68 65 64 2F 31 32 2E 41 44 30
--016: 30 42 34 44 30 42 45 34 32 2F 70 61 67 65 73 2F
--032: 70 61 67 65 2E 30 00
Note how the last 2 (actual data) bytes are absent in the later example.
| Commit | Date |
|---|