Menu
▾
▴
Code Merge Request #72: finish secure camera when screen is off (open)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Daniel Zhang wants to merge 1 commit from /u/danielzhang130/opencamera/ to master, 2024-01-20
Behavior change which I think is more user friendly.
This mimics the behavior of AOSP camera2 and uses the same approach.
What changed:
1. after unlocked and camera is open, lock phone with power button, wake phone with power button, camera is no longer shown (running in secure mode now), instead the lock screen is shown. This is more user friendly because I think when the user locks the phone, he/she is most likely done with taking pictures. When the phone is waken up, probably after a few minutes of user away from phone, more likely than not, the user wants to check what's on the lockscreen, time, notifications, etc and not keep taking pictures. The user probably has forgotten that he/she was taking pictures a few minutes ago and would be confused as to why the camera pops into view.
2. Secure camera would automatically turn off after the screen is off
| Commit | Date | |
|---|---|---|
| 2024-01-07 01:40:50 | Tree |
I was wondering, how are you getting Open Camera to run when locked in the first place, and what device is this?
For me, the option to press power button twice no longer seems to offer any options for third party cameras on my Galaxy S10e and Pixel 6 Pro (only the stock camera runs), so it seemed to be something less commonly available these days. And although the change would make sense, for such devices it would mean there is no way to get Open Camera running when locked at all - unless I'm missing another way to get Open Camera running when locked?
Have you tried clearing the default opening option for the stock camera app? Long press the app icon, then app info, then open by default, clear default preferences. Then next time you double click the power button, it should ask you switch camera app to use.
Though I don't know if this will work. I don't run stock OS. I run my own build of Android. So I don't know what OEM are doing these days.
I had a look at this, Google Camera on my Pixel has no defaults set, also double checked under Settings/Apps/"Default apps" (which doesn't even show a default for camera), I think this is something various companies (including Google) have stopped supporting.
So I'll have to think about this I'm afraid - on many devices it won't be possible to have Open Camera behave the way that stock cameras behave, so the "Show camera when locked" option provides an alternative way.
To clarify, I run my own custom build of Android, but I don't think there are any modification from AOSP to make open camera work in lock screen. Maybe the OEM builds locked things down.