Minor issue in versioncheck.php
Brought to you by:
wizonet
Menu
▾
▴
#20 Minor issue in versioncheck.php
Found a very minor issue with the version check on the 'support' page- possibly it doesn't affect everyone.
I'm not using a proxy, and I'm at php 7.2.11 on centos8- pretty much 'bleeding edge'- this may be a php issue with stream_context_create
The version check was timing out- error:
file(http://api.wizonet.ch/nagiosql/versioncheck.php?myversion=3.4.1&mygit=2020-01-19): failed to open stream: HTTP request failed! (check proxy settings)
very consistently- probably worked 1 time in 30.
I tweaked line 74 in versioncheck.php, and made it '1.1' (it's a float), and it started working way more consistently (I've not seen it fail yet, but I haven't run for more than an hour with my change)
This one is a bit tricky- perhaps there should be a configuration check to ensure the default socket timeout is set and sane before using the timeout setting? (my system default is 60 seconds- I haven't touched that in my php config, so I assume that's what most have)
What this likely means (assuming no php bugs) is that from where I am in the US, the wizonet server is taking just a little bit too long to respond.
timeout=1 means, that the socket timeout is set to 1 second, while the default is 60 seconds. You increase this now to 1.1 seconds and it works :)
I think you can set this to 2-5 seconds without any negative effect :)
I will increase this value to 2 seconds in the next GIT hotfix. The only result of this will be that it takes up to 2 seconds for the page to load
Of course.
I'm just trying to think of ways to make it a little 'slicker'. (I suppose rewiting the whole thing to put an ajax-y 'this version is out of date and needs an update' into the header, loaded in the background, is a bit further than needs to be...)