[go: up one dir, main page]
Menu ▾ ▴

#2112 WSL: dirname and basename functions should move to `__mingwrt_` namespace

WSL
assigned
Earnie Boyd
None
Task
none
Unknown
True
2013-10-20
2013-10-19
Keith Marshall
No

As noted on ticket [#2098], the dirname() function pollutes the namespace, by virtue of a gratuitous reference within the runtime startup code; it should move to the __mingw_ namespace, to avoid this.

For symmetry, its libgen sibling, basename() should move with it.

1 Attachments
issue-2112.patch

Related

Issues: #2098
Issues: #2111
Issues: #2113

Discussion

  • Keith Marshall

    Keith Marshall - 2013-10-19
    • assigned_to: Keith Marshall --> Earnie Boyd
    • Patch attached: False --> True
     

  • Keith Marshall

    Keith Marshall - 2013-10-19

    I've attached a patch to address this. It also reinstates the missing author attribution info, pre-empting addition to [#2111].

     

    Related

    Issues: #2111

  • Keith Marshall

    Keith Marshall - 2013-10-20

    Should have added: attached patch is not independent; it follows the series:--

    1. dirent-2106.patch [#2106]
    2. issue-2098.patch [#2098]
    3. issue-2112.patch (this patch)
     

    Related

    Issues: #2098
    Issues: #2106