Re: [LogiLogi-list] UI Integration - Names of boxes
Status: Beta
Brought to you by:
wybow
|
From: Wybo W. <wy...@lo...> - 2008-09-17 10:52:34
|
I just committed some more wireing up and integration. The new_logilogi.html is now integrated in the trunk :) (hope we can work on the trunk now...) Some bits may not have been copied over, especially regarding the secondary tabs, as I did not know what to do with those... I also made a start with hooking up remarks, but while doing that, and really already when adding the commenting logis, I ran across the naming of the bordered boxes, especially the different colored ones (those that should be differently colored in line with the svg)... Now most start with class="logi_current logi", and that may not be neatest... Now I bet you already planned on changing that, but maybe we should give all the boxes the same name, like border_box, or something, and then determine the color via the css, based on the div they are in... (just like we do with the primary tabs) (except maybe for the current logi, or the selected contender) This would make the styling clean, and really separate from the html (and allow putting the code needed for the box in a single layout partial, just like app/views/application/round_box.html.erb for the rounded boxes)... So if you like it that way, you can do it... --- I also did an attempt of fixing the min_height keeper in the current logi, with an overflow: auto, but it required setting the width of the logi_body manually... dunno if there is a better solution, as this one also breaks the border of the current logi... --- In all fixes I did I sticked closely to the SVG, and I am using Firefox 3.0.1 on linux for it... Hope it is not too different from the other Firefoxes... greetings, Wybo PS: I might come online again late tonight if it's still early enough :) I have a documentary and discussion-evening with friends tonight, and it might get late... In any case I will be back tomorrow morning for a good day of devving (but no more integration as changes to the trunk from now on)... |