Re: [LogiLogi-list] UI Integration - Editing
Status: Beta
Brought to you by:
wybow
|
From: Wybo W. <wy...@lo...> - 2008-09-17 01:52:44
|
First of all miguel, I hope you got ll to work on your OSX... (tried to make up something of the chat-conversation, but I fear my Spanish is too bad). I just integrated the new_logilogi.html, that is largely. However unless you have to work on windows or something and cannot run logilogi, I think improvements should be made next time directly in trunk, as the little extra work there saves a lot of hassling with re-integrating stuff later on again... (1,5 hour spent now, and still not entirely done). Also this allows you to commit early and often, and me to do a fix here and there, as now I basically have to wait for you to add / fix things as we might be working on the same bits (& we don't really have that time with the deadline of the 20th / 23rd & at the pace we're now working...)... Still some questions: http://logilogi.svn.sourceforge.net/viewvc/logilogi/docs/ui-designs/html/new_logilogi.html?r1=1102&r2=1114 Around line 288 / 280 what did you do here ? As the secondary tabs are not at all related to main, changes, etc, but to search, browse, etc like in the old file. --- #main #secondarytabs_main, #logis #secondarytabs_logis, #changes #secondarytabs_changes, #groups #secondarytabs_groups, #users #secondarytabs_users, #help #secondarytabs_help { --- Around line 516 / 523 you renamed the secondary tabs to stuff like secondarytabs_full_text_search, while in the trunk it is secondarytabs_search, as the tab-text is search there too... Some bits still don't look equal, like the comment-logi having the avatar above the title in the merged version, and some margin problem, but I will fix it in the trunk and commit it in my next commit... (& when committing the integration for the first time some small things were also fixed, like absolute paths for images & I also now renamed the sidebox-images in rounded to box, for consistency) greetings, Wybo |