Re: [LogiLogi-list] Public beta updated!

> First of all; good work on the UI-side of the link-removal. I played
> around a bit with it, and it seems to be working good now! :)
> 
> (& it seems very intuitive!)
> 
> > > commented that out in the menu... About the unit-test; doing the
> > > calculations on the position-ranges should be covered by the
> > > position-ranges lib under libs... So let me know if the old
> > > implementation worked or not...
> > 
> > We looked at the PositionRange class and used some methods for
> > remove_links_from_position_ranges and made the unit test work.
> > 
> > It is not possible to use the substract method of PositionRange. If
> > you substract a link which begin and end position is smaller than
> > another link from that link, you have to get two new position
> > ranges. (e.g. 1..8 - 2...5 must be 1..2 and 5..8)
> 
> This is strange, as I've added quite a lot of tests to the
> PositionRange lib on this, and I've added your case now to line 135 of
> the lib/position_range/tests/position_range_list_test.rb, and it 
> exactly 
> does what you say above here...:
> 
> assert_equal PositionRange::List.from_s('1,2:5,8'),
>    PositionRange::List.from_s('1,8') - 
> PositionRange::List.from_s('2,5')
> Also I have commented out your code in logi.rb and added a test to the
> unit-test logi_test.rb where the middle-part of a link is removed, 
> and 
> it works.
> 
> At first it was not saved, but line 325 seems to be enough to take
> care of that.
> 
> If you find problems in the current solution, please let me know,
> otherwise you can remove the commented out code.
>
Sorry, you're right. It works with the current code.

I also tried to add a svg remove-cross, but there is a problem with WEBrick not sending it with the good mime-type. So I commented out the svg section and added it as png.

The fixes you made in showLogiLink were not correct. The reason why we store the popover in root is that with link-removal sometimes the listing_url changes (when links are removed) and we have to reload the content of the baloon. In my last commit I added this again.

> greetings,
> 
> Wybo
> 
> ---
>